Improve error context in asherah.go#72
Merged
jgowdy-godaddy merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
Enhanced error messages with additional context to aid debugging: - Database connection errors now include the DB type (mysql/postgres) - Replica read consistency errors show the attempted value - Unknown metastore type errors list valid options - KMS creation errors include the KMS type and configuration - AWS KMS errors include the preferred region All errors now use fmt.Errorf with error wrapping for better stack traces.
Add redactConnectionString() to scrub credentials before logging, handling both MySQL DSN (user:pass@tcp) and PostgreSQL URL (postgres://user:pass@host) formats.
jgowdy-godaddy
force-pushed
the
improve-error-context
branch
from
4ad1720 to
c6b1917
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced error messages with additional context to aid debugging in production environments.
Changes
Implementation
fmt.Errorfwith error wrapping for better stack tracesTest plan