Fix multiple bugs found during code review#83
Merged
jgowdy-godaddy merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
- Fix Setup() race condition: use CompareAndSwap instead of Load/Store - Fix wrong variable in SetupJson error log (result vs stringResult) - Fix panic re-throw in FFI exports: return ERR_PANIC instead of re-panicking across FFI boundary (undefined behavior) - Make DisableZeroCopy atomic to prevent data race - Close DB connection in Shutdown to prevent resource leak - Add missing error log in Decrypt not-initialized path - Check os.Setenv errors in SetEnv instead of silently ignoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
result(from BufferToJsonStruct) instead ofstringResult(from BufferToString)ERR_PANIC(-106) via named return values instead.-race. Now usesatomic.Bool.dbconnectionwas opened but never closed, leaking the resource.ERR_BAD_CONFIG.Test plan
go vetcleango buildclean