Skip to content

feat: add new tab option #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbicuti-godaddy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add new tab option #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdfab3b
feat: add new tab option
cbicuti-godaddy Aug 29, 2023
dd3d38f
feat: update minified files
cbicuti-godaddy Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions .dev/src/blocks/domain-search/inspector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,13 @@ const Inspector = ( { attributes, setAttributes } ) => {
/>
</Fragment>
) }
{ 'advanced' !== attributes.search_type && (
Copy link
Contributor

@cburton-godaddy cburton-godaddy Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (non-blocking): I guess this 'advanced' !== attributes.search_type is no longer needed as all types of search have this option?

<Fragment>
<CheckboxControl
label={ __( 'Display results in a new tab', 'reseller-store' ) }
checked={ attributes.new_tab }
onChange={ ( new_tab ) => setAttributes( { new_tab } ) }
/>
</Fragment>
) }
<Fragment>
<CheckboxControl
label={ __( 'Display results in a new tab', 'reseller-store' ) }
checked={ attributes.new_tab }
onChange={ ( new_tab ) => setAttributes( { new_tab } ) }
/>
</Fragment>
</PanelBody>
</InspectorControls>
);
Expand Down
6 changes: 1 addition & 5 deletions assets/js/domain-search.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion assets/js/editor.blocks.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion class-plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ final class Plugin {
*
* @var string
*/
const VERSION = '2.2.14';
const VERSION = '2.2.15';

/**
* Plugin prefix.
Expand Down
9 changes: 9 additions & 0 deletions includes/modules/rstore-fl-domain-search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,15 @@ public function __construct() {
'label' => __( 'Deselect Button', 'reseller-store' ),
'default' => __( 'Selected', 'reseller-store' ),
),
'new_tab' => array(
'type' => 'select',
'label' => __( 'Display results in a new tab', 'reseller-store' ),
'default' => '0',
'options' => array(
'1' => __( 'Yes', 'reseller-store' ),
'0' => __( 'No', 'reseller-store' ),
),
),
),
),
),
Expand Down
1 change: 1 addition & 0 deletions includes/widgets/class-domain-search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ private function get_data( $instance ) {
'text_select' => isset( $instance['text_select'] ) ? $instance['text_select'] : apply_filters( 'rstore_text_select', esc_html__( 'Select', 'reseller-store' ) ),
'text_selected' => isset( $instance['text_selected'] ) ? $instance['text_selected'] : apply_filters( 'rstore_text_selected', esc_html__( 'Selected', 'reseller-store' ) ),
'modal' => isset( $instance['modal'] ) ? ! empty( $instance['modal'] ) : apply_filters( 'rstore_domain_modal', false ),
'new_tab' => isset( $instance['new_tab'] ) ? $instance['new_tab'] : false,
);
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"build": "grunt build"
},
"dependencies": {
"domain-search": "^4.0.1"
"domain-search": "^4.0.2"
},
"devDependencies": {
"@babel/core": "^7.21.8",
Expand Down
6 changes: 5 additions & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
**Requires at least:** 4.6
**Tested up to:** 6.2.2
**Requires PHP:** 5.4
**Stable tag:** 2.2.14
**Stable tag:** 2.2.15
**License:** GPL-2.0
**License URI:** https://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -103,6 +103,10 @@ You can add `?domainToCheck=example.com` to your query string on any page that h

## Changelog ##

### 2.2.15 - August 2023 ###

* Update: Add option to open cart in a new tab for Advanced Domain Search

### 2.2.14 - August 2023 ###

* Update: Add option to open cart and search results in new tab
Expand Down
6 changes: 5 additions & 1 deletion readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Tags: reseller, program, storefront, products, posts, shortcode, ec
Requires at least: 4.6
Tested up to: 6.2.2
Requires PHP: 5.4
Stable tag: 2.2.14
Stable tag: 2.2.15
License: GPL-2.0
License URI: https://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -99,6 +99,10 @@ You can add `?domainToCheck=example.com` to your query string on any page that h

== Changelog ==

= 2.2.15 - August 2023 =

* Update: Add option to open cart in a new tab for Advanced Domain Search

= 2.2.14 - August 2023 =

* Update: Add option to open cart and search results in new tab
Expand Down
2 changes: 1 addition & 1 deletion reseller-store.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/**
* Plugin Name: Reseller Store
* Description: Sell hosting, domains, and more right from your WordPress site.
* Version: 2.2.14
* Version: 2.2.15
* Author: GoDaddy
* Author URI: https://reseller.godaddy.com/
* License: GPL-2.0
Expand Down