Skip to content

Require that classes starting with "Editor" be marked internal #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

Require that classes starting with "Editor" be marked internal #1272

merged 1 commit into from
Aug 18, 2025

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Aug 11, 2025 •
edited
Loading

Make this edge case explicit to users: create_dialog.cpp#L171-L173

Effect:

#[derive(GodotClass)]
#[class(init)]
pub struct EditorObject {}
image

The current PR does not allow registering classes starting with Editor in <4.2 at all, but we're anyway going to phase out Godot 4.1 for godot-rust v0.4.

@Bromeon Bromeon added this to the 0.4 milestone Aug 11, 2025
@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: register Register classes, functions and other symbols to GDScript breaking-change Requires SemVer bump labels Aug 11, 2025
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1272

@Bromeon Bromeon force-pushed the master branch 2 times, most recently from 779c043 to ddc5b76 Compare August 18, 2025 19:16
@Bromeon Bromeon added this pull request to the merge queue Aug 18, 2025
Merged via the queue into master with commit d7c6485 Aug 18, 2025
18 checks passed
@Bromeon Bromeon deleted the qol/hide-editor-prefix branch August 18, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Requires SemVer bump c: register Register classes, functions and other symbols to GDScript quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Bromeon @GodotRust