Skip to content

Commit a4409a9

Browse files
committed
Use debug feature in bindings generator; fix related issue not detected in CI
1 parent bf45fa3 commit a4409a9

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

.github/workflows/full-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ env:
3232

3333
# Local variables
3434
# Note: using variables is limited at the moment, see https://github.com/actions/runner/issues/480
35-
GDRUST_FEATURES: "gdnative/async,gdnative/serde"
35+
GDRUST_FEATURES: "gdnative/async,gdnative/serde,gdnative_bindings_generator/debug"
3636
CARGO_DENY_VERSION: "0.11.0"
3737
CARGO_DINGHY_VERSION: "0.4.68"
3838

.github/workflows/minimal-ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ env:
1313
# Local variables
1414
# Note: using variables is limited at the moment, see https://github.com/actions/runner/issues/480
1515
GODOT_VER: "3.4.1"
16+
17+
# Don't use more features like "gdnative_bindings_generator/debug" to keep CI truly minimal
1618
GDRUST_FEATURES: "gdnative/async,gdnative/serde"
1719

1820
on:

.github/workflows/release-version.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ on:
88
- '0.10.[0-9]+-?*'
99

1010
env:
11-
GDRUST_FEATURES: "gdnative/async,gdnative/serde"
11+
# Note: used for test and clippy, not for publish
12+
GDRUST_FEATURES: "gdnative/async,gdnative/serde,gdnative_bindings_generator/debug"
1213

1314
# Crates to publish -- important, this doesn't work when there are spaces in any of the paths!
1415
GDRUST_CRATES: >

bindings-generator/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ pub(crate) mod test_prelude {
225225

226226
let api = Api::new(include_str!("../../gdnative-bindings/api.json"));
227227
let mut buffer = BufWriter::new(Vec::with_capacity(16384));
228-
for class in api.classes {
228+
for class in &api.classes {
229229
let mut icalls = HashMap::new();
230230

231231
let code = generate_module_doc(&class);

0 commit comments

Comments
 (0)