Include API documentation in the editor #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devloglogan
approved these changes
Feb 19, 2025
Collaborator
devloglogan
left a comment
devloglogan
left a comment
There was a problem hiding this comment.
Looks good, browsing the docs in the editor just fine. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hate that I noticed this only a couple hours after making the 1.0.1 release :-/
We weren't including the API documentation in the GDExtension itself so it could be read in the editor. This PR fixes that!
Given that the docs can be read online, I don't know that this on it's own is worth making a 1.0.2 release right away? I think we can hang on to it until we gather up a couple more fixes, which are sure to happen after the public announcement and more folks are testing it