Add Meta Prebuilt APK Install Tool #18

devloglogan · 2025-06-30T20:53:48Z

This PR builds on top of the work in #15

For ease of review I've kept commits separate, including a commit that runs .clang-format on all of the c++ files. Some of the updates / additions to Fredia's work:

Updated the export process to check the new vendor plugin project settings.
generatePrebuiltApks now serves as a standalone task, it won't be run when building the plugin.
- To run generatePrebuiltApks it needs to be pointed to a godot directory with -Pgodot_dir=path/to/godot
- This will create a meta-export-template.zip file in the project root, with the idea that we'll host them here in releases of the Godot Meta Toolkit.
- I've removed the godot submodule since it's now longer needed.
Added an editor tool that downloads/installs the export the prebuilt apks.
- Download url is created form a new base url editor setting (default pointing towards this github repo) and I've added a GODOT_META_TOOLKIT_VERSION define in a new file version.h.

dsnopek

Thanks! This looks great :-)

I've only got a couple notes/questions on the code

Otherwise, the only other important thing to note here is that this will only work with Godot 4.5 (because we need EditorExportPlugin::_update_android_prebuilt_manifest()) and so merging this will make the plugin 4.5+

We'll want to consider when we want to do this, or if we want to make two builds (one that's 4.3+ and another that's 4.5+), or maybe two major versions?

If we go with two builds, we could come up with a way to have a single codebase, where we wrap the new code with #if GODOT_VERSION_PATCH >= 5, which will check if the provided extension_api.json is for Godot 4.5 or later. Then we just need CI to make two builds with two different extension_api.jsons

dsnopek · 2025-06-30T20:58:56Z

build.gradle

+                if (godotDir == "") {
+                    throw new GradleException("godot_dir property is required")
+                }


This should probably check that the directory exists as well. And since this needs to be done in a bunch of places, it probably makes sense to move this check into a function

Added checking that it exists / is a directory, and extracted it out to a verifyGodotDir() function.

build.gradle

toolkit/src/main/cpp/include/version.h

toolkit/src/main/cpp/editor/meta_export_template_dialog.cpp

The previous logic only uses `ANDROID_ENABLED` to gate the Platform SDK logic, which causes it to be active when the addon is loaded in the Android / XR editor. The updated logic adds an editor specific build for the Android / XR editor which disables the Platform SDK logic.

m4gr3d · 2025-11-11T20:43:33Z

prebuilt/AndroidManifest.xml

+        <activity
+            android:name=".GodotApp"
+            android:exported="true"
+            tools:node="merge">
+            <intent-filter>
+                <action android:name="android.intent.action.MAIN" />
+                <category android:name="android.intent.category.LAUNCHER" />
+
+                <!-- Enable access to OpenXR on Oculus mobile devices, no-op on other Android
+                platforms. -->
+                <category android:name="com.oculus.intent.category.VR" />
+
+                <!-- OpenXR category tag to indicate the activity starts in an immersive OpenXR mode.
+                See https://registry.khronos.org/OpenXR/specs/1.0/html/xrspec.html#android-runtime-category. -->
+                <category android:name="org.khronos.openxr.intent.category.IMMERSIVE_HMD" />
+            </intent-filter>
+        </activity>


This will need to be updated following the work in https://github.com/m4gr3d/godot/tree/add_front_door

Can you provide more detail on this? That link doesn't appear to lead anywhere. 🙂

m4gr3d · 2025-11-11T20:45:23Z

thirdparty/godot_cpp_build_profile/build_profile.json

+        "XRInterface",
+        "ZIPReader"
    ]
 }


Missing newline.

m4gr3d · 2025-11-13T22:11:41Z

toolkit/src/main/cpp/editor/meta_export_template_dialog.cpp

+					break;
+				}
+
+				bool install_failed = false;


install_failed doesn't seem to be updated in the following logic.

m4gr3d · 2025-11-13T22:19:01Z

toolkit/src/main/cpp/export/meta_toolkit_export_plugin.cpp

+		overrides["gradle_build/min_sdk"] = "29"; // Android 10
+		overrides["gradle_build/target_sdk"] = "32"; // Android 12
+	} else {
+		overrides["gradle_build/use_gradle_build"] = false;


Let's remove this given the progress being made on the gradle build and let's have the min_sdk and target_sdk reflect the values from above.

m4gr3d · 2025-11-13T22:21:28Z

toolkit/src/main/cpp/export/meta_toolkit_export_plugin.cpp

+	}
+
+	if (_get_bool_option("meta_xr_features/quest_3_support")) {
+		supported_devices.append("quest3");


Let's also add quest3s as done in https://github.com/GodotVR/godot_openxr_vendors/blob/3b4fb43d4e88be334f0ce73244490216861f46fd/plugin/src/main/cpp/export/meta_export_plugin.cpp#L220

m4gr3d · 2025-11-13T22:24:29Z

toolkit/src/main/cpp/export/meta_toolkit_export_plugin.cpp

+	// Check for scene api.
+	bool use_scene_api = ProjectSettings::get_singleton()->get_setting_with_override("xr/openxr/extensions/meta/scene_api");
+	if (use_scene_api) {
+		r_permissions.append("com.oculus.permission.USE_SCENE");
+	}


This should also check for environment depth as done in https://github.com/GodotVR/godot_openxr_vendors/blob/3b4fb43d4e88be334f0ce73244490216861f46fd/plugin/src/main/cpp/export/meta_export_plugin.cpp#L418

m4gr3d

Some feedback to address, but it looks good overall.

devloglogan force-pushed the apk-export-support branch 4 times, most recently from 8198f06 to fc442f0 Compare June 30, 2025 21:08

dsnopek reviewed Jun 30, 2025

View reviewed changes

devloglogan force-pushed the apk-export-support branch 2 times, most recently from 1dc17a9 to cf444dd Compare July 1, 2025 18:33

devloglogan added the enhancement New feature or request label Jul 3, 2025

dsnopek added this to the 2.0.0 milestone Jul 11, 2025

m4gr3d and others added 4 commits July 28, 2025 15:31

Add support for exporting Meta's prebuilt apks

21a6786

Update apk export to check vendor repo project settings

52c2be0

Add Meta prebuilt APK install tool

104e440

devloglogan force-pushed the apk-export-support branch from cf444dd to 104e440 Compare July 28, 2025 21:10

m4gr3d mentioned this pull request Nov 5, 2025

Add support for exporting Meta's prebuilt apks #15

Closed

m4gr3d reviewed Nov 11, 2025

View reviewed changes

thirdparty/godot_cpp_build_profile/build_profile.json

"XRInterface",

"ZIPReader"

]

}

Copy link

Collaborator

m4gr3d Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline.

m4gr3d reviewed Nov 13, 2025

View reviewed changes

m4gr3d approved these changes Nov 13, 2025

View reviewed changes

Uh oh!

Add Meta Prebuilt APK Install Tool #18

Are you sure you want to change the base?

Add Meta Prebuilt APK Install Tool #18

Uh oh!

Conversation

devloglogan commented Jun 30, 2025

Uh oh!

dsnopek left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

m4gr3d Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

m4gr3d left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dsnopek left a comment •

edited

Loading

m4gr3d Nov 13, 2025 •

edited

Loading