SCons: Integrate cache_limit from main repo
#1671
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
added
enhancement
Repiteo
force-pushed
the
scons/cache-limit
branch
from
e092a96 to
c58c6e0
Compare
Ivorforce
reviewed
Dec 13, 2024
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
I'm probably a bit late to comment on the PR, since I'm guessing Godot upstream has the same (or similar) code merged already. Feel free to close any that aren't up for discussion anymore.
Repiteo
force-pushed
the
scons/cache-limit
branch
from
c58c6e0 to
9dcf8f9
Compare
Contributor
Author
|
Actually, seeing as this repo uses a "proper" integration of SCons, a much more native approach is probably possible. In particular, the ability to avoid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
godot-cpp-testfrom workflow to action godot#97742Code brought over virtually verbatim from the main repo where relevant. This will allow the main repo to utilize caching for
godot-cppin a way that can be safely constrained, as well as constraining caching for this repo (though it will never reach that new limit in practice)