Skip to content

Conversation

@dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Nov 1, 2025

Fixes #1876

This implements option nr 1, which I guess I'm leaning to, because it's the least surprising. This option has only existed for a short time, so changing the default shouldn't be too big of a deal

@dsnopek dsnopek added this to the 4.x milestone Nov 1, 2025
@dsnopek dsnopek added the bug This has been identified as a bug label Nov 1, 2025
@dsnopek dsnopek requested a review from a team as a code owner November 1, 2025 13:33
@enetheru enetheru self-requested a review November 2, 2025 00:47
Copy link
Collaborator

@enetheru enetheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@enetheru
Copy link
Collaborator

enetheru commented Nov 2, 2025

I dont know how to propose changes inline in the code, but in the linux.cmake:22

set(STATIC_CPP "$<BOOL:${GODOTCPP_USE_STATIC_CPP}>")

can be changed to:

    set(STATIC_CPP "$<AND:$<BOOL:${GODOTCPP_USE_STATIC_CPP}>,$<BOOL:${GODOTCPP_USE_HOT_RELOAD}>>")

99.9% sure this is correct, I just cant test on linux atm.

@dsnopek
Copy link
Collaborator Author

dsnopek commented Nov 2, 2025

I'm not sure if I'm reading it correctly, but it looks like your change would set STATIC_CPP if both GODOTCPP_USE_STATIC_CPP and GODOTCPP_USE_HOT_RELOAD are enabled?

If so, I don't think that's what we want. If anything, I think we'd want it to only be set if GODOTCPP_USE_HOT_RELOAD is not enabled, but that's what #1877 does and I think that's a little problematic. The goal of this PR was just to change the default of use_static_cpp and GODOTCPP_USE_STATIC_CPP to disabled.

@enetheru
Copy link
Collaborator

enetheru commented Nov 3, 2025

crap I thought thats the PR i was commenting on, thanks.

Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@dsnopek dsnopek merged commit 44a7d6b into godotengine:master Nov 11, 2025
16 checks passed
@dsnopek
Copy link
Collaborator Author

dsnopek commented Nov 30, 2025

Cherry-picked for 4.4 in PR #1890

@dsnopek
Copy link
Collaborator Author

dsnopek commented Nov 30, 2025

Cherry-picked for 4.5 in PR #1891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enabling "use_static_cpp" breaks hot reload on Linux

3 participants