-
-
Notifications
You must be signed in to change notification settings - Fork 704
On Linux default use_static_cpp to disabled
#1878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Linux default use_static_cpp to disabled
#1878
Conversation
enetheru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I dont know how to propose changes inline in the code, but in the linux.cmake:22 set(STATIC_CPP "$<BOOL:${GODOTCPP_USE_STATIC_CPP}>")can be changed to: set(STATIC_CPP "$<AND:$<BOOL:${GODOTCPP_USE_STATIC_CPP}>,$<BOOL:${GODOTCPP_USE_HOT_RELOAD}>>")99.9% sure this is correct, I just cant test on linux atm. |
|
I'm not sure if I'm reading it correctly, but it looks like your change would set STATIC_CPP if both If so, I don't think that's what we want. If anything, I think we'd want it to only be set if |
|
crap I thought thats the PR i was commenting on, thanks. |
Ivorforce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
|
Cherry-picked for 4.4 in PR #1890 |
|
Cherry-picked for 4.5 in PR #1891 |
Fixes #1876
This implements option nr 1, which I guess I'm leaning to, because it's the least surprising. This option has only existed for a short time, so changing the default shouldn't be too big of a deal