Skip to content

chore: Update the link to predefined color mappings for Icons. #10766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyace65 merged 4 commits into from
Mar 17, 2025
Merged

chore: Update the link to predefined color mappings for Icons. #10766

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c788b9
fix: Update link to color map from 4.0.2 -> 4.4.
Kuraiou Mar 7, 2025
3174962
Merge branch 'godotengine:master' into patch-1
Kuraiou Mar 14, 2025
c89f991
fix: use the stable tag instead of the branch.
Kuraiou Mar 14, 2025
bddda22
fix: unpin specific lines and branch so this won't break in the future.
Kuraiou Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contributing/development/editor/creating_icons.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Color conversion for light editor themes

If the user has configured their editor to use a light theme, Godot will
convert the icon's colors based on a
`set of predefined color mappings <https://github.com/godotengine/godot/blob/4.0.2-stable/editor/editor_themes.cpp#L60-L160>`__.
`set of predefined color mappings <https://github.com/godotengine/godot/blob/4.4/editor/themes/editor_color_map.cpp#L48-L156>`__.
This is to ensure the icon always displays with a sufficient contrast rate.
Try to restrict your icon's color palette to colors found in the list above.
Otherwise, your icon may become difficult to read on a light background.
Expand Down