Add additional information about the Godot XR Vendor Plugin #11515
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
reviewed
Dec 4, 2025
BastiaanOlij
force-pushed
the
openxr_vendor_info
branch
3 times, most recently
from
50b6bbf to
05efaab
Compare
BastiaanOlij
force-pushed
the
openxr_vendor_info
branch
from
05efaab to
8f198c9
Compare
dsnopek
approved these changes
Dec 5, 2025
Contributor
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me :-)
AThousandShips
approved these changes
Dec 5, 2025
devloglogan
reviewed
Dec 5, 2025
mhilbrunner
approved these changes
Dec 6, 2025
BastiaanOlij
force-pushed
the
openxr_vendor_info
branch
from
8f198c9 to
80585a2
Compare
skyace65
approved these changes
Dec 7, 2025
Contributor
skyace65
left a comment
skyace65
left a comment
There was a problem hiding this comment.
Looks good to me. Though in the future I may want to revisit this to add more specific detail on what does and doesn't require the plugin.
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the vendor plugin is optional, added a note to that in the documentation making clear the vendor plugin is still important.
Also added a section in next steps to underline that the vendor plugin isn't just useful on AOSP devices, but also to unlock vendor extensions on other platforms.
This includes a link to the client support matrix where users can find which OpenXR extensions are supported in core, and which require the vendor plugin.