Documentation: add information about Apple Bundle IDs#11809
Merged
mhilbrunner merged 3 commits intogodotengine:masterfrom Mar 21, 2026
Merged
Documentation: add information about Apple Bundle IDs#11809mhilbrunner merged 3 commits intogodotengine:masterfrom
mhilbrunner merged 3 commits intogodotengine:masterfrom
Conversation
AThousandShips
requested changes
Mar 3, 2026
178838e to
d544a4a
Compare
specifically, for macOS & iOS builds
d544a4a to
1f9fef3
Compare
Contributor
Author
|
I've removed the changes to the classes/ folder and added in AThousandShips' suggestions (sorry for being messy with my force pushes) |
AThousandShips
approved these changes
Mar 3, 2026
Member
AThousandShips
left a comment
There was a problem hiding this comment.
Style looks good! Will need a review from the relevant team to confirm the facts
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Calinou
reviewed
Mar 3, 2026
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
mhilbrunner
approved these changes
Mar 21, 2026
Member
|
Merged! Thank you, and thanks for the reviews people. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds correct information on bundle IDs to both the manual and the class reference.
The class reference previously implied that the bundle ID had to be in reverse-DNS format, but as far as I can see that isn't the case (it just has to be unique and meet the character requirements listed here).
I was tempted to add similar information for android exports, but since its
Bundle Identifierbox currently supports auto-generation withcom.example.$gennameas a default, I didn't see this as necessary.