Draft: Quickfix extra quotes by removing them from LSP response#913
Draft: Quickfix extra quotes by removing them from LSP response#913nick-loginov wants to merge 2 commits intogodotengine:masterfrom
Conversation
nick-loginov
changed the title
|
I WAS going to tell you I've tried this by rewriting the incoming messages and it was so unreliable that I'm not interested in a client side bandaid fix anymore, but I've never seen this middleware mechanism. I'm very interested to test this out. |
|
Yeah, I'm still testing it right now, and you're right, it's all junky and there is more stuff to make it work as intended. In current state only works for simple cases. |
|
No problem. We can also slap a setting in front of this and mark it experimental. I have some other dirty hacks that I think would be cleaner if I move them to this middleware layer, so this PR won't be wasted even if the quote thing doesn't work out. |
|
@DaelonSuzuka I was going to ask what exactly was the problem in your attempts? Did some of the cases not work? Can you give some examples? I'm convinced it's possible to make it reliable |
|
That was a looong time ago now so I don't remember the specifics. I could get it working in like, one specific test scenario but it broke when I tried to generalize it. |
|
I'd prefer to fix this properly in the server so I started working on that godotengine/godot#117710 But if you want to add a workaround for it anyway feel free to do so, just wanted to cross link this. |
|
@HolonProduction I fully agree, (and thanks for fixing this!) |
3 participants
Fixes #885