Merge pull request #103641 from darksylinc/matias-mobile-shadows-update

Repiteo · Repiteo · commit 0fb08045463a · 2025-03-11T09:35:05.000-05:00
Fix inefficient upload in Mobile Shadows
diff --git a/servers/rendering/renderer_rd/forward_mobile/render_forward_mobile.cpp b/servers/rendering/renderer_rd/forward_mobile/render_forward_mobile.cpp
@@ -1419,6 +1419,7 @@ void RenderForwardMobile::_render_shadow_begin() {
 	_update_render_base_uniform_set();
 
 	render_list[RENDER_LIST_SECONDARY].clear();
+	scene_state.instance_data[RENDER_LIST_SECONDARY].clear();
 }
 
 void RenderForwardMobile::_render_shadow_append(RID p_framebuffer, const PagedArray<RenderGeometryInstance *> &p_instances, const Projection &p_projection, const Transform3D &p_transform, float p_zfar, float p_bias, float p_normal_bias, bool p_use_dp, bool p_use_dp_flip, bool p_use_pancake, float p_lod_distance_multiplier, float p_screen_mesh_lod_threshold, const Rect2i &p_rect, bool p_flip_y, bool p_clear_region, bool p_begin, bool p_end, RenderingMethod::RenderInfo *p_render_info, const Transform3D &p_main_cam_transform) {

Original file line number	Diff line number	Diff line change
`@@ -1419,6 +1419,7 @@ void RenderForwardMobile::_render_shadow_begin() {`
`1419`	`1419`	`_update_render_base_uniform_set();`
`1420`	`1420`
`1421`	`1421`	`render_list[RENDER_LIST_SECONDARY].clear();`
	`1422`	`+ scene_state.instance_data[RENDER_LIST_SECONDARY].clear();`
`1422`	`1423`	`}`
`1423`	`1424`
`1424`	`1425`	void RenderForwardMobile::_render_shadow_append(RID p_framebuffer, const PagedArray<RenderGeometryInstance > &p_instances, const Projection &p_projection, const Transform3D &p_transform, float p_zfar, float p_bias, float p_normal_bias, bool p_use_dp, bool p_use_dp_flip, bool p_use_pancake, float p_lod_distance_multiplier, float p_screen_mesh_lod_threshold, const Rect2i &p_rect, bool p_flip_y, bool p_clear_region, bool p_begin, bool p_end, RenderingMethod::RenderInfo p_render_info, const Transform3D &p_main_cam_transform) {