Skip to content

Commit e98d608

Browse files
authored
Merge pull request #110033 from SK83RJOSH/pdb-base-name-fix
Fix `WindowUtils::copy_and_rename_pdb` regression
2 parents 041207f + 4115071 commit e98d608

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

platform/windows/windows_utils.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ Error WindowsUtils::copy_and_rename_pdb(const String &p_dll_path) {
180180
ERR_FAIL_COND_V_MSG(original_path_size < min_base_size + suffix_size, FAILED, vformat("The original PDB path size in bytes is too small: '%s'. Expected size: %d or more bytes, but available %d.", pdb_info.path, min_base_size + suffix_size, original_path_size));
181181

182182
new_pdb_base_name.clear();
183-
new_pdb_base_name.append_utf8(utf8_name, original_path_size - suffix_size);
183+
new_pdb_base_name.append_utf8(utf8_name.get_data(), original_path_size - suffix_size);
184184
new_pdb_base_name[new_pdb_base_name.length() - 1] = '_'; // Restore the last '_'
185185
WARN_PRINT(vformat("The original path size of '%s' in bytes was too small to fit the new name, so it was shortened to '%s%d.pdb'.", pdb_info.path, new_pdb_base_name, max_pdb_names - 1));
186186
}

0 commit comments

Comments
 (0)