Capitalize PRINT_VERBOSE macro to match other macros
#100224
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
2 times, most recently
from
fd356d5 to
33341d2
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
3 times, most recently
from
2bce9c6 to
d4087f4
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
3 times, most recently
from
118a968 to
0985dea
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
2 times, most recently
from
53111e1 to
f4de73e
Compare
This was referenced May 7, 2025
aaronfranke
changed the title
PRINT_VERBOSE macro to avoid a conflict with UtilityFunctionsPRINT_VERBOSE macro to match other macros
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
from
f4de73e to
cd0fb47
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
from
cd0fb47 to
a1ba06f
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
2 times, most recently
from
8552ea9 to
1500ff5
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
from
1500ff5 to
e213fbb
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
from
e213fbb to
af6b843
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
from
af6b843 to
86d16c3
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
2 times, most recently
from
4f9034a to
485ac96
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
from
485ac96 to
41585eb
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
2 times, most recently
from
1c571c4 to
7f2f889
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
from
7f2f889 to
80007d1
Compare
aaronfranke
force-pushed
the
print-verbose-macro-caps
branch
from
80007d1 to
6123028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: #106147 should be merged first, so I have marked this as draft.
This PR changes the
print_verbosemacro toPRINT_VERBOSE, for 3 reasons:UtilityFunctions: Fixprint_verbose()macro conflicting withUtilityFunctions::print_verbose()godot-cpp#1668VariantUtilityFunctions, avoiding this awkwardness:This PR may minorly affect compatibility with third-party modules, but does not change the exposed scripting API. However, it is trivial for third-party modules to either update their code or add
print_verboseas an alias.