Add EditorAcceptDialog for easier handling of UndoRedo#102899
Open
KoBeWi wants to merge 1 commit intogodotengine:masterfrom
Open
Add EditorAcceptDialog for easier handling of UndoRedo#102899KoBeWi wants to merge 1 commit intogodotengine:masterfrom
KoBeWi wants to merge 1 commit intogodotengine:masterfrom
Conversation
KoBeWi
force-pushed
the
EditorAcceptDialogWithShortcutInputAndUndoRedo
branch
2 times, most recently
from
722f0f5 to
5fd5744
Compare
KoBeWi
force-pushed
the
EditorAcceptDialogWithShortcutInputAndUndoRedo
branch
from
5fd5744 to
50de8ef
Compare
AdriaandeJongh
approved these changes
Feb 20, 2026
Contributor
AdriaandeJongh
left a comment
AdriaandeJongh
left a comment
There was a problem hiding this comment.
Good addition from a usability perspective, and indeed perhaps something that can be applied to more panels that are lacking undo/redo. Haven't looked at the code.
KoBeWi
force-pushed
the
EditorAcceptDialogWithShortcutInputAndUndoRedo
branch
from
50de8ef to
f0b8f7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #93898 (comment)
Also adds undo/redo support for theme import dialog. If you have your favorite dialog that doesn't support undo/redo, comment so I can change it too.