-
-
Notifications
You must be signed in to change notification settings - Fork 23.6k
Updates and fixes to the Android prebuilt export logic #103173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates and fixes to the Android prebuilt export logic #103173
Conversation
82c5a0f to
042430d
Compare
e336383 to
405db3e
Compare
405db3e to
08cfcfb
Compare
dcbb98d to
64936fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is really great. :-) I like how it unifies some of the manifest changes (metadata and features) in both Gradle and APK-based builds.
I tested doing an OpenXR build using just an APK-based export (with an APK built from godot-sdk-integrations/godot-meta-toolkit#15) and it worked great. I also "decompiled" the APK with apktool and the manifest all looks good.
However, I'm not sure this is a good one for cherry-picking, at least not right away. There's the virtual method that's added here (which we don't usually add in patch releases), but it also just seems like a lot of changes. Maybe wait until it's gotten a bunch more testing in 4.5-dev releases first? I know there's some fixes mixed in here too - if some of them don't depend on the feature changes, maybe they could be extracted to another PR?
I've dropped the |
64936fe to
8103226
Compare
8103226 to
c55a6c9
Compare
c55a6c9 to
845c925
Compare
|
I think it might be a good idea to also add an option in the Export window to add |
|
Thanks! |
Updates
meta-datatags for the prebuilt export logic_update_android_prebuilt_manifestfor gdextension plugins to hook into and update the Android prebuilt apk at export timeFixes
uses-featuretags for the prebuilt export logicgradlebuildgradlebuild requirement for enablingOpenXRmissing templateserror to show even when the user defines valid custom templates