OpenXR: Fix ViewportTextures not displaying correct texture (OpenGL) #110002
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
added
bug
topic:rendering
topic:xr
regression
cherrypick:4.5
This was referenced Aug 27, 2025
dsnopek
approved these changes
Aug 27, 2025
clayjohn
approved these changes
Aug 28, 2025
|
Thanks! |
|
Cherry-picked to 4.5 |
Repiteo
removed
the
cherrypick:4.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies a fix to the compatibility renderer that makes
ViewportTexturework properly with an overridden color buffer on the texture.Note
This PR extracts the changes to the compatibility renderer from #109955
As these changes are pretty straight forward, this PR can likely go ahead without waiting on further discussion on the Vulkan changes.
This is functionality that has been broken since the introduction of the compatibility renderer but is a regression from this feature in Godot 3. It comes up in user complaints every few months. It can be worked around at the cost of performance (performing a separate render).
It would be nice to take along in the Godot 4.5 release as the changes are unlikely to have an impact however a cherry pick to 4.5.1 is reasonable.
See godotengine/godot-demo-projects#1144 for a demo of the functionality (requires a PCVR headset).