Ignore backfaces during Node3D selection #110185
Open
+20
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also be implemented for remote selection. |
vaner-org
force-pushed
the
selection-ignore-backfaces
branch
from
d388708 to
746aa1d
Compare
✔️ Done. |
vaner-org
force-pushed
the
selection-ignore-backfaces
branch
from
746aa1d to
d43059d
Compare
vaner-org
force-pushed
the
selection-ignore-backfaces
branch
from
d43059d to
4325e1f
Compare
Calinou
approved these changes
Sep 2, 2025
There was a problem hiding this comment.
Tested locally on https://github.com/Calinou/godot-reflection, it works as expected. Code looks good to me.
In the example below, the camera is stuck inside geometry.
Before
ignore_backfaces_before.mp4
After
ignore_backfaces_after.mp4
|
Does it need to be a setting? Why would someone want to turn it off? |
I can't see a reason to turn it off, so I think the setting should be removed too. We can introduce it in a future PR if there's a proven need for it. |
vaner-org
force-pushed
the
selection-ignore-backfaces
branch
from
4325e1f to
93195f5
Compare
|
I've removed the editor setting and hardcoded our two calls to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12550.
Adds an editor setting3D > Ignore Backfaces on Selectionthat istrueby default.Adds an optional parameter and an if statement to TriangleMesh's
intersect_rayfunction.