Skip to content

[TextServer] Shape emojis as separate runs. #110194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[TextServer] Shape emojis as separate runs. #110194

wants to merge 1 commit into from
+44 −9

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 2, 2025

Fixes #110143

Before:
Screenshot 2025-09-02 at 11 17 31

After:
Screenshot 2025-09-02 at 11 16 51

@bruvzg bruvzg added this to the 4.6 milestone Sep 2, 2025
@bruvzg bruvzg requested a review from a team as a code owner September 2, 2025 10:04
Calinou
Calinou approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

Did you mean "runes" instead of "runs" in the commit message though?

@bruvzg
Copy link
Member Author

bruvzg commented Sep 3, 2025

Did you mean "runes" instead of "runs" in the commit message though?

Nop, "run" as a sequence of characters to shape, emojis are assigned a dedicated script code and therefore shaped on their own, not with the surrounding text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.

Font system fallback emoji missing important glyphs with Inter font
2 participants
@bruvzg @Calinou