Skip to content

Allow all ColorPicker Shapes to expand horizontally #110218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow all ColorPicker Shapes to expand horizontally #110218

wants to merge 1 commit into from
+3 −1

Conversation

WhalesState
Copy link
Contributor

Before:

Screencast.From.2025-09-03.09-18-26.mp4

After:

Screencast.From.2025-09-03.09-19-12.mp4

@WhalesState WhalesState requested a review from a team as a code owner September 3, 2025 06:21
@AThousandShips AThousandShips added this to the 4.x milestone Sep 3, 2025
bruvzg
bruvzg reviewed Sep 3, 2025
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stretching rectangular shapes (and centering the rest) definitely make sense.

Swatches container probably should be stretched as well:

Image

@WhalesState
Copy link
Contributor Author

WhalesState commented Sep 3, 2025 •
edited
Loading

Swatches container probably should be stretched as well:

I will soon open another PR fixing the swatches and the recent color presets to use FoldableContainer and to scroll horizontally to reduce the height of the color ColorPicker when there are many colors like this and we can merge both together to fix this issue.

Edit: Swatches uses GridContainer with a fixed size so they can't be expanded unless we make it a FlowContainer or an HBoxContainer + ScrollContainer like the video.

Screencast.From.2025-09-03.12-03-38.mp4

@WhalesState
Copy link
Contributor Author

Honestly, I see this more as a bug fix than a feature proposal.

image

KoBeWi
KoBeWi reviewed Sep 3, 2025
View reviewed changes
@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
4 participants
@WhalesState @KoBeWi @bruvzg @AThousandShips