Use AABB center instead of origin for visibility fade #113486
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttencate
changed the title
akien-mga
changed the title
clayjohn
approved these changes
Dec 6, 2025
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
Makes sense, we use AABB center everywhere else, so let's keep it the same for now.
We can likely consider matching the behaviour of LODs later (computing distance to nearest face of the AABB)
clayjohn
added
the
cherrypick:4.5
Contributor
|
Thanks! |
Contributor
|
Awesome, I am excited for this one as it will simplify my manual LOD system for trees in my game! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79471
Fixes #102799
I've also sent godotengine/godot-docs#11511 to fix the docs, because the distance was always computed to the AABB center, never to the origin (except in this buggy case).