[4.3] Cherry-pick Windows build system fixes to fix command too long error#113846
Open
aaronfranke wants to merge 3 commits intogodotengine:4.3from
Open
[4.3] Cherry-pick Windows build system fixes to fix command too long error#113846aaronfranke wants to merge 3 commits intogodotengine:4.3from
aaronfranke wants to merge 3 commits intogodotengine:4.3from
Conversation
TEMPFILE is the built-in way of SCons to use a response file for command lines that are too long. (cherry picked from commit 28b95ff)
Set `TEMPFILEARGESCFUNC`[1] to replace backslashes with forward slashes in paths. [1]: https://scons.org/doc/production/HTML/scons-user/apa.html#cv-TEMPFILEARGESCFUNC (cherry picked from commit 4542516)
It's not clear what is the actual max value that windows support, but despite their claim of it being 8191 we have been seeing failure with just 8150. (cherry picked from commit 395a4fc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks PR #96407, PR #97188, and PR #97458, fixing issue #99710 in the Godot 4.3 branch. In general 4.3 is considered EOL, but buildsystem fixes are still valid to backport.
I have a large module which supports multiple Godot versions, all the way back to Godot 4.3. However, the module is now big enough that I am getting an error "The command line is too long" when compiling on Windows (it actually doesn't trigger on my machine, but it triggers on CI and on another person's machine, and I believe it's gotta be close to the limit on my machine too).
This PR cherry-picks those 3 PRs to fix this problem. I have tested that this works, the CI successfully compiles with these fixes.
Disclaimer: I am far from an expert on this specific code. The only thing I have done is perform the cherry-picks and test that this fixes the problem. I did not test every combination of the individual PRs to see which specific ones are needed to fix the problem, I just tested all of them in one go and it worked.