Skip to content

Conversation

@ndarilek
Copy link
Contributor

@ndarilek ndarilek commented Jan 5, 2026

  • Add accessibility names to EditorSpinSlider, inspector scrollbar, and settings categories tree
  • Propagate property labels to focusable controls in EditorProperty::set_label
  • Eliminate duplicate tab stops by setting EditorProperty to FOCUS_NONE when it has focusable children
  • Fix EditorSettingsPropertyWrapper to pass label and set proper focus mode
  • Skip setting empty 'Property:' accessibility names

@ndarilek ndarilek requested review from a team as code owners January 5, 2026 19:00
@bruvzg bruvzg self-requested a review January 5, 2026 19:08
@bruvzg bruvzg added this to the 4.x milestone Jan 5, 2026
@ndarilek ndarilek force-pushed the editor-project-settings-a11y branch from f885b8a to 09a010a Compare January 5, 2026 19:50
@ndarilek ndarilek marked this pull request as draft January 6, 2026 16:18
@ndarilek ndarilek force-pushed the editor-project-settings-a11y branch from 09a010a to 843d9dd Compare January 6, 2026 16:20
@ndarilek ndarilek force-pushed the editor-project-settings-a11y branch from 843d9dd to 0493d75 Compare January 19, 2026 13:31
- Add accessibility names to EditorSpinSlider, inspector scrollbar, and settings categories tree
- Propagate property labels to focusable controls in EditorProperty::set_label
- Eliminate duplicate tab stops by setting EditorProperty to FOCUS_NONE when it has focusable children
- Fix EditorSettingsPropertyWrapper to pass label and set proper focus mode
- Skip setting empty 'Property:' accessibility names
- Make EditorInspector non-focusable since it's a container with no useful keyboard interaction
- Remove redundant "On" text from boolean property checkboxes
@ndarilek ndarilek force-pushed the editor-project-settings-a11y branch from 0493d75 to a279a7f Compare January 19, 2026 18:42
@ndarilek ndarilek marked this pull request as ready for review January 19, 2026 18:43
@ndarilek
Copy link
Contributor Author

Probably not perfect but this substantially improves the screen reader usability for me of the editor and project settings dialogs by:

  • Removing lots of unused tab stops, especially some that didn't seem to have any usable keyboard controls.
  • Automatically labeling property controls.
  • Removing "On" from checked checkboxes.

I'm now able to confidently navigate these dialogs in my fork.

@ndarilek ndarilek marked this pull request as draft January 20, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants