Skip to content

Use AHashMap for built-ins functions in shaders #114692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Chaosus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use AHashMap for built-ins functions in shaders #114692

Chaosus wants to merge 1 commit into from
+1,212 −1,258

Conversation

@Chaosus
Copy link
Member

@Chaosus Chaosus commented Jan 7, 2026 •
edited
Loading

This change should improve overall compile performance for the shaders with a lot of built-in function usage, because:

    1. The name string checking is removed
    1. The tag checking is removed
    1. It will search only on specific function subset from a AHashMap by string key

Also, this should reduce the binary size, by removing redundant members from BuiltinFuncDef.

@Chaosus Chaosus requested a review from a team as a code owner January 7, 2026 17:42
@Chaosus Chaosus added this to the 4.7 milestone Jan 7, 2026
@Chaosus Chaosus force-pushed the shader_builtin_improvements branch 3 times, most recently from 8be8a9f to 1c70b85 Compare January 7, 2026 18:35
@Chaosus Chaosus force-pushed the shader_builtin_improvements branch from 1c70b85 to acfacec Compare January 7, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement performance topic:shaders

Projects

None yet

Milestone

4.7

Development

Successfully merging this pull request may close these issues.

1 participant

@Chaosus