add check to disable running metrics server when port is set to 0

[Umang01-hash]

Pull Request Template

Description:

• Closes Make metrics disabled when port is explicitly set to 0 #2789.

Checklist:

• I have formatted my code using goimport and golangci-lint.
• All new code is covered by unit tests.
• This PR does not decrease the overall code coverage.
• I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

[coolwednesday]

Can we instead have a disable variable introduce ...better serves the purpose. 0 is also a valid port. Hence I do not want to use it as a boolean.

[coolwednesday]

#2790 (comment)

[Umang01-hash]

@coolwednesday Thanks for the valuable feedback. However, setting Port 0 = disabled is an established cloud-native convention, kubernetes also follow this convention. Introducing an additional variable for disabling it will lead to user remembering multiple configs for a single feature which is not the best behaviour.

[coolwednesday]

Okay Sure.

[coolwednesday]

Can we also update somewhere in documentation.