Skip to content

Add latency unit field in JSON logs#3152

Open
Babai-69 wants to merge 2 commits intogofr-dev:mainfrom
Babai-69:fix-json-latency-unit
Open

Add latency unit field in JSON logs#3152
Babai-69 wants to merge 2 commits intogofr-dev:mainfrom
Babai-69:fix-json-latency-unit

Conversation

@Babai-69
Copy link

Added latencyUnit field in JSON logs to make latency values explicit.

Changes made:

  • Added ResponseUnit field in log struct
  • Added "µs" in gRPC logs
  • Added "µs" in HTTP middleware logs
  • Updated related test files

@Umang01-hash
Copy link
Member

Hey @Babai-69 !
Thanks for the effort to make GoFr better. Your PR currently have this issue that the PKG Unit Testing step in workflow is failing with the following error :

Screenshot 2026-03-17 at 2 47 22 PM

Also it will be nice if you can attach the screenshot for the new grpc and http logs so that other reviewers can easily verify the changes.

@Babai-69 Babai-69 force-pushed the fix-json-latency-unit branch from cd970d7 to 5f5ff70 Compare March 18, 2026 13:58
@Babai-69
Copy link
Author

Babai-69 commented Mar 18, 2026

Thanks for pointing it out. I added the missing ResponseUnit field in RequestLog and pushed the fix.

Attaching sample screenshots for updated HTTP and gRPC logs showing the new latencyUnit field for easier verification.

grpc-log png http-log png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants