-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: add transaction support for dgraph migration #3186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krisp619
wants to merge
6
commits into
gofr-dev:development
Choose a base branch
from
krisp619:fix-dgraph-transaction
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+175
−32
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2d667ab
fix: add transaction support for dgraph migration
cee32da
fix: handle discard error logging in dgraph migration
113497a
Merge branch 'development' into fix-dgraph-transaction
Umang01-hash 1ddde83
Merge branch 'development' into fix-dgraph-transaction
Umang01-hash 3ab220e
fix: add transaction observability and tests for dgraph migration
6a6b299
fix: finalize dgraph migration tests and resolve syntax issues
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commitMigrationhas a new failure path whenc.DGraph.NewTxn()doesn't implement the expected transaction interface, but the tests only cover mutate/commit errors. Add a test case whereNewTxn()returns a non-transaction object (ornil) and asserterrInvalidDgraphTxnis returned to prevent regressions in this guard logic.