Fix quick links navigation#167
Merged
naveen-bandela-au2 merged 2 commits intogofr-dev:mainfrom Jun 25, 2025
Merged
Conversation
Contributor
Author
|
@coolwednesday Could you please review this? Also, I had a doubt—can you check my comment on the original issue I linked? Thanks! |
coolwednesday
approved these changes
Jun 20, 2025
Member
coolwednesday
left a comment
coolwednesday
left a comment
There was a problem hiding this comment.
LGTM. @naveen-bandela-au2 , Please review.
naveen-bandela-au2
requested changes
Jun 24, 2025
Collaborator
naveen-bandela-au2
left a comment
naveen-bandela-au2
left a comment
There was a problem hiding this comment.
@Ari1009 QuickLink is used at multiple places with any link please make href props as optional one and also use div if tag if href is not passed, if it passed use <a tag
Member
|
@Ari1009, Re-request review from the reviewer to get your PR approved. |
Contributor
Author
|
@naveen-bandela-au2 can I get a review, Thnx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the QuickLink component to properly handle hrefs, fixing the broken Quick Start and Examples buttons. Now correctly links to the docs introduction and GitHub examples.
Related to issue gofr-dev/gofr#1870
2025-06-19.17-26-26.mp4