[WIP] Add multi token SDK setup support #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikpatel351
force-pushed
the
multi-extension-support
branch
from
2437caa to
f773b90
Compare
Zissan
reviewed
Nov 29, 2023
| try { | ||
| const clusterId = req.params.cluster_id; | ||
| if (clusterId) { | ||
| extension = ExtensionFactory.getExtension(clusterId) |
Zissan
reviewed
Nov 29, 2023
Zissan
reviewed
Nov 29, 2023
Zissan
reviewed
Nov 29, 2023
Zissan
reviewed
Nov 29, 2023
Zissan
reviewed
Nov 29, 2023
| try { | ||
| const cluster_id = req.params.cluster_id; | ||
| if (cluster_id) { | ||
| ext = ExtensionFactory.getExtension(cluster_id) |
- Specific routes will be matched first based on routing logic of Express so moving cluster id based route as first
Zissan
reviewed
Nov 30, 2023
| const clusterId = req.params.cluster_id; | ||
| if (clusterId) { | ||
| extension = ExtensionFactory.getExtension(clusterId) | ||
| } |
There was a problem hiding this comment.
req.extension = extension;
Injection of extension instance in the request object will be helpful to get the cluster_id
vivek-gofynd
pushed a commit
that referenced
this pull request
Jan 4, 2024
pooransuthar1999
force-pushed
the
multi-extension-support
branch
from
3262b72 to
8713884
Compare
pooransuthar1999
force-pushed
the
multi-extension-support
branch
from
8713884 to
5134791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should be able to set up multiple extensions on a single server for the Background worker.
Removed singleton extension object.