fix: delegate scene.Renderer rasterization to SoftwareRenderer#125
Merged
fix: delegate scene.Renderer rasterization to SoftwareRenderer#125
Conversation
Replace broken internal rasterizer with delegation to gg.SoftwareRenderer. Fixes: no AA, stroke ignoring curves, background destruction, no alpha compositing. Zero public API changes — orchestration (tiles, workers, cache) preserved.
This was referenced Feb 23, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #124 (reported in #116)
Details
The scene.Renderer had its own simplified rasterizer written before
gg.SoftwareRendererand the GPU pipeline existed. Following the universal pattern confirmed by Qt Quick, Skia, Vello, and Flutter/Impeller — scene graph orchestrates, immediate-mode backend rasterizes — the pixel rendering is now delegated toSoftwareRenderer.Changed:
fillPathOnTile/strokePathOnTile→ delegate tosr.Fill()/sr.Stroke()compositeTile→ premultiplied source-over alpha blending (was rawcopy())sync.Poolfor per-tile SoftwareRenderer and Pixmap reusescene.Path(float32) →gg.Path(float64) with tile offsetfillPathOnTile,strokePathOnTile,drawLineOnTile,blendPixelDocs:
Test plan
go build ./...clean (GOWORK=off)go test ./...— 38 packages OKgolangci-lint run— 0 issuesgo fmt— clean