[nydus] Remove old config's reference in config descriptor's annotations when adding empty layer#353
Merged
imeoer merged 1 commit intogoharbor:mainfrom Oct 13, 2025
Conversation
…ons when adding empty layer Trying to push a manifest with an added empty layer to ECR currently fails because the manifest's config descriptor has an annotation field with a referrence to the old config digest. The failure is ` Invalid parameter at 'ImageManifest' failed to satisfy constraint: 'Invalid JSON syntax'`. This field should be accepted by ECR because it's present in the spec but since there is no hard need to keep it as an annotation on the config descriptor, this commit remove the annotation entirely since the original config can still be discovered by finding the original OCI manifest using the digest stored in the new manifest annotations. Signed-off-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com>
Fricounet
force-pushed
the
fricounet/oci-config-ann
branch
from
2994941 to
d66f72d
Compare
Collaborator
|
Thanks, LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to push a manifest with an added empty layer to ECR currently fails because the manifest's config descriptor has an annotation field with a referrence to the old config digest.
The failure is
Invalid parameter at 'ImageManifest' failed to satisfy constraint: 'Invalid JSON syntax'.This field should be accepted by ECR because it's present in the spec but since there is no hard need to keep it as an annotation on the config descriptor, this PR removes the annotation entirely since the original config can still be discovered by finding the original OCI manifest using the digest stored in the new manifest annotations.