[adapter] Use context without cancel for GC#354
Merged
imeoer merged 1 commit intogoharbor:mainfrom Oct 13, 2025
Merged
Conversation
The GC triggered in a goroutine after the Convert operation is done was called with the same context passed down. However, when the convert action is called synchronously (accelctl --sync), the associated context is canceled when the sync operation is completed. Since the GC was run after, it was failing with a `context canceled` error. To solve this, we now remove the `cancel` from the context passed down to the GC. Signed-off-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com>
741e524 to
a8bec59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GC triggered in a goroutine after the Convert operation is done was called with the same context passed down. However, when the convert action is called synchronously (accelctl --sync), the associated context is canceled when the sync operation is completed. Since the GC was run after, it was failing with a
context cancelederror. To solve this, we now remove thecancelfrom the context passed down to the GC.The issue was easy to reproduce: