-
Notifications
You must be signed in to change notification settings - Fork 103
Feature: Moving to pure Dagger based CI/CD Pipeline from Goreleaser #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
440c2e4 to
1552c71
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
=========================================
- Coverage 10.99% 6.44% -4.55%
=========================================
Files 173 260 +87
Lines 8671 12842 +4171
=========================================
- Hits 953 828 -125
- Misses 7612 11908 +4296
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have commented improvements
cb31d76 to
bd0b3db
Compare
bupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NucleoFusion added my suggestions
d6b7eb5 to
566f133
Compare
bupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Missing docker publish. |
|
@bupd The docker publish is in the Dagger tracker, and I have added that as the highest priority. |
78ae385 to
9937990
Compare
bupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is bleeding out of its scope.
the scope is to replace the goreleaser with dagger. So any parts which were previously not been involved with goreleaser should stay the same as it is.
77f6448 to
022ae35
Compare
|
@bupd my mistake sorry, I was so focused on making it fit with the theme/structure I had, I didnt pay attention that it got out of scope. I will fix this. |
8ce2430 to
e94c67d
Compare
bupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
2a01f31 to
ca7bda0
Compare
bupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NucleoFusion resolve conflicts and remove the v in the tags following the previous release artifact naming
… also removing goreleaser dependency Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
…inaries Signed-off-by: NucleoFusion <[email protected]>
…t dependency on others Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]> fix: env variable name fix Signed-off-by: NucleoFusion <[email protected]> fix: adding publish to the pipeline Signed-off-by: NucleoFusion <[email protected]> fix: creating release with publish-release and modifying token Signed-off-by: NucleoFusion <[email protected]> fix: fixed token malformed error Signed-off-by: NucleoFusion <[email protected]> fix: fixed improper call Signed-off-by: NucleoFusion <[email protected]> fix: fixed issue with folder being uploaded Signed-off-by: NucleoFusion <[email protected]> fix: fixing duplicate name error Signed-off-by: NucleoFusion <[email protected]> fix: splitting release creation and file upload Signed-off-by: NucleoFusion <[email protected]> fix: removing nfpm.yml upload Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]> fix: updating name for file Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]> fix: quotes on the release title Signed-off-by: NucleoFusion <[email protected]> fix: small workflow fixes Signed-off-by: NucleoFusion <[email protected]> fix: repo mismatch fix Signed-off-by: NucleoFusion <[email protected]> fix: uncomment Signed-off-by: NucleoFusion <[email protected]> fix: fixing token issue Signed-off-by: NucleoFusion <[email protected]> fix: build error Signed-off-by: NucleoFusion <[email protected]> fix: resolving 404 error Signed-off-by: NucleoFusion <[email protected]> fix: resolving name mismatch error Signed-off-by: NucleoFusion <[email protected]> fix: switching to goharbor/harbor-cli Signed-off-by: NucleoFusion <[email protected]> fix: readding cosign dependency & updated README.md Signed-off-by: NucleoFusion <[email protected]> fix: README fix Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]> fix: filepath mismatch for checksum Signed-off-by: NucleoFusion <[email protected]> fix: renaming to use checksums.txt Signed-off-by: NucleoFusion <[email protected]> fix: renaming to use checksums.txt Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: Prasanth Baskar <[email protected]>
Signed-off-by: NucleoFusion <[email protected]> temp: removing publish dependency on testing Signed-off-by: NucleoFusion <[email protected]> fix: binary build error Signed-off-by: NucleoFusion <[email protected]> fix: not releasing erropr Signed-off-by: NucleoFusion <[email protected]> fix: changing for goharbor/harbor-cli Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]> fix: adding back publish-release dependency on test-code Signed-off-by: NucleoFusion <[email protected]> test Signed-off-by: NucleoFusion <[email protected]> test Signed-off-by: NucleoFusion <[email protected]> test Signed-off-by: NucleoFusion <[email protected]> test Signed-off-by: NucleoFusion <[email protected]> test Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Co-authored-by: Prasanth Baskar <[email protected]> Signed-off-by: Nucleo Fusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]> fix: fixed build-dev error Signed-off-by: NucleoFusion <[email protected]> refactor: refactoring Build and Archive functions to be separate Signed-off-by: NucleoFusion <[email protected]> refactor: refactoring other functions Signed-off-by: NucleoFusion <[email protected]> fix: temp removal of test dependency Signed-off-by: NucleoFusion <[email protected]> fix: adding export in gh actions Signed-off-by: NucleoFusion <[email protected]> fix: removing export in release call Signed-off-by: NucleoFusion <[email protected]> fix: error in release, nil values Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]> fix: source mismatch Signed-off-by: NucleoFusion <[email protected]> fix: missing utils fix Signed-off-by: NucleoFusion <[email protected]> fix: apt repo Signed-off-by: NucleoFusion <[email protected]> fix: docker publish Signed-off-by: NucleoFusion <[email protected]> fix: missing dist folder Signed-off-by: NucleoFusion <[email protected]> fix: image tags error Signed-off-by: NucleoFusion <[email protected]> fix: adding verbosity Signed-off-by: NucleoFusion <[email protected]> fix: no such file, ./harbor Signed-off-by: NucleoFusion <[email protected]> fix: no such file, ./harbor Signed-off-by: NucleoFusion <[email protected]> fix: missing ':' Signed-off-by: NucleoFusion <[email protected]> fix: missing flag for build-dir Signed-off-by: NucleoFusion <[email protected]> fix: missing ending quotes Signed-off-by: NucleoFusion <[email protected]> fix: fix Signed-off-by: NucleoFusion <[email protected]> fix: fix Signed-off-by: NucleoFusion <[email protected]> fix: fix Signed-off-by: NucleoFusion <[email protected]> fix: fix Signed-off-by: NucleoFusion <[email protected]> fix: fix Signed-off-by: NucleoFusion <[email protected]> fix: fix Signed-off-by: NucleoFusion <[email protected]> fix: test Signed-off-by: NucleoFusion <[email protected]> fix: test Signed-off-by: NucleoFusion <[email protected]> fix: test Signed-off-by: NucleoFusion <[email protected]> fix: test Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]> fix: fox Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
Signed-off-by: NucleoFusion <[email protected]>
985278f to
038d3ba
Compare
Signed-off-by: NucleoFusion <[email protected]> test Signed-off-by: NucleoFusion <[email protected]> test Signed-off-by: NucleoFusion <[email protected]> test Signed-off-by: NucleoFusion <[email protected]>
2a02428 to
19bbdb7
Compare
Completed Release
The release binaries are here,
https://github.com/NucleoFusion/harbor-cli/releases/tag/v0.2.54
We only miss the SBOM's from the current release structure.
Apt repo
The apt repo files are here,
https://github.com/NucleoFusion/harbor-cli/tree/gh-pages
PS: Now updated so that only
Packages.gzis therePublish and Image
The images are at,
https://hub.docker.com/repository/docker/nucleofusion/harbor-cli
PS: Now re-use binaries instead of re-creation
Homebrew
The homebrew formula/PR for cron is at,
goharbor/homebrew-tap#5
PS: Now supports mac and linux both
Tracking Issue
#553
Releases
Misc