fix(ci): fix vulnerability check failure in dagger pipeline #588
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @bupd kindly review this whenever you are free. Thanks! |
Currently, the vulnerability check fails inside Dagger when bugs are found, preventing the report from being exported. This change adds error handling (|| true) to the govulncheck command to ensure the report is always generated. Vulnerability check ultimately results in a failure at github actions stage. Signed-off-by: Rayyan Khan <[email protected]>
rkcoder101
force-pushed
the
fix/vulnerability-check-pipeline
branch
from
4848e4f to
bf6369d
Compare
Contributor
Author
|
Hi @bupd the tests failed last time due to unavailability of demo.goharbor.io. I have force pushed again, please run the tests whenever you are free. Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
=========================================
- Coverage 10.99% 6.44% -4.55%
=========================================
Files 173 260 +87
Lines 8671 12842 +4171
=========================================
- Hits 953 828 -125
- Misses 7612 11908 +4296
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #552
Description
Currently, the vulnerability check fails inside Dagger when bugs are found, preventing the report from being exported. This change adds error handling (|| true) to the govulncheck command to ensure the report is always generated. Vulnerability check ultimately results in a failure at github actions stage.
Attached is the video of the fixed bug
simplescreenrecorder-2025-12-30_23.12.23.mp4