Skip to content

test/Unit tests for user command #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rkcoder101 wants to merge 9 commits into from
Closed

test/Unit tests for user command #653

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
65854bd
test/Unit tests for user list command and ListUser view
rkcoder101 Jan 27, 2026
aa5e605
test/Wrote unit tests for GetUsers (which was separated out in the la…
rkcoder101 Jan 28, 2026
33220eb
test/Wrote test for UserListCmd; functions which it calls have alread…
rkcoder101 Jan 28, 2026
dd19759
test/Separated out CreateUser function from UserCreateCmd, and wrote …
rkcoder101 Jan 30, 2026
cabbf8d
test/Separated DeleteUser() from UserDeleteCmd() and wrote the unit t…
rkcoder101 Jan 30, 2026
2ea5091
test/Separated ElevateUser() from ElevateUserCmd() and wrote unit tes…
rkcoder101 Jan 31, 2026
10cefcd
fix, test: decouple password logic to fix empty payload bug and add u…
rkcoder101 Jan 31, 2026
97ecd30
one minor fix, removed personal commments
rkcoder101 Jan 31, 2026
b30c211
fix/Added piping to capture the output to stdout (instead of using Fp…
rkcoder101 Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 35 additions & 30 deletions cmd/harbor/root/user/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,36 @@ import (
"github.com/spf13/cobra"
)

type UserCreator interface {
FillUser(opts *create.CreateView)
UserCreate(opts create.CreateView) error
}
type DefaultUserCreator struct{}

func (d *DefaultUserCreator) FillUser(opts *create.CreateView) {
create.CreateUserView(opts)
}

func (d *DefaultUserCreator) UserCreate(opts create.CreateView) error {
return api.CreateUser(opts)
}
func CreateUser(opts *create.CreateView, userCreator UserCreator) {
var err error

if opts.Email == "" || opts.Realname == "" || opts.Password == "" || opts.Username == "" {
userCreator.FillUser(opts)
}

err = userCreator.UserCreate(*opts)

if err != nil {
if isUnauthorizedError(err) {
log.Error("Permission denied: Admin privileges are required to execute this command.")
Copy link
Collaborator

@bupd bupd Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robot accounts can also create users - this is not limited to admins.

Copy link
Contributor Author

@rkcoder101 rkcoder101 Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will correct this 👍

} else {
log.Errorf("failed to create user: %v", err)
}
}
}
func UserCreateCmd() *cobra.Command {
var opts create.CreateView

Expand All @@ -31,30 +61,8 @@ func UserCreateCmd() *cobra.Command {
Short: "create user",
Args: cobra.ExactArgs(0),
Run: func(cmd *cobra.Command, args []string) {
var err error
createView := &create.CreateView{
Email: opts.Email,
Realname: opts.Realname,
Comment: opts.Comment,
Password: opts.Password,
Username: opts.Username,
}

if opts.Email != "" && opts.Realname != "" && opts.Comment != "" && opts.Password != "" && opts.Username != "" {
err = api.CreateUser(opts)
} else {
err = createUserView(createView)
}

// Check if the error is due to unauthorized access.

if err != nil {
if isUnauthorizedError(err) {
log.Error("Permission denied: Admin privileges are required to execute this command.")
} else {
log.Errorf("failed to create user: %v", err)
}
}
d := &DefaultUserCreator{}
CreateUser(&opts, d)
},
}

Expand All @@ -67,12 +75,9 @@ func UserCreateCmd() *cobra.Command {

return cmd
}

func createUserView(createView *create.CreateView) error {
create.CreateUserView(createView)
return api.CreateUser(*createView)
}

func isUnauthorizedError(err error) bool {
if err == nil {
return false
}
return strings.Contains(err.Error(), "403")
}
Loading
Loading