Add support for trivy dbRepository and javaDBRepository by benji78 · Pull Request #1857 · goharbor/harbor-helm

benji78 · 2024-11-11T16:41:37Z

This adds support for custom trivy dbRepository and javaDBRepository which was made possible through SCANNER_TRIVY_DB_REPOSITORY and SCANNER_TRIVY_JAVA_DB_REPOSITORY environment variables added in goharbor/harbor-scanner-trivy/pull/3.

Closes #1821

Vad1mo

can you point me to the upstream Trviy documentation?

I can't find anything related to SCANNER_TRIVY_DB_REPOSITORY in trivy.

benji78 · 2024-11-12T12:31:19Z

Here is the documentation for --db-repository and --java-db-repository. I added the environment variables in harbor-scanner-trivy through the mentioned pull request.

benji78 · 2024-11-17T18:29:31Z

I will add support for multiple database repositories and mark the pull request as ready along with goharbor/harbor-scanner-trivy#7 as soon as trivy has decided which repositories to put as default.

values.yaml

github-actions · 2025-03-30T09:04:34Z

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

github-actions · 2025-05-31T09:05:17Z

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

LeclerT · 2025-06-03T09:43:12Z

+1
Where is the progress of this feature ? Thanks in advance

templates/trivy/trivy-sts.yaml

MinerYang

lgtm

feat: support multiple db repositories Signed-off-by: Benjamin Bordes <benjaminbordes78@gmail.com> fix template error && add unittest for trivy db repository Signed-off-by: my036811 <miner.yang@broadcom.com>

wy65701436

lgtm

it's good to go

MinerYang · 2025-09-03T08:00:14Z

Hi @benji78,

Thanks for contributing to harbor-helm, and this new feature would delivered along with harbor-helm v1.18.0(app version v2.14.0).

Best,
Miner

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [harbor](https://goharbor.io) ([source](https://github.com/goharbor/harbor-helm)) | minor | `1.17.2` -> `1.18.0` | --- ### Release Notes <details> <summary>goharbor/harbor-helm (harbor)</summary> ### [`v1.18.0`](https://github.com/goharbor/harbor-helm/releases/tag/v1.18.0) [Compare Source](goharbor/harbor-helm@v1.17.2...v1.18.0)  Harbor OSS version: v2.14.0 #### What's Changed ##### Other Changes - Fix: fix bug where log level configuration was not applied by [@sisilia91](https://github.com/sisilia91) in [#2167](goharbor/harbor-helm#2167) - Added existingSecretAdminPassword to the values.yaml file by [@rkthtrifork](https://github.com/rkthtrifork) in [#2180](goharbor/harbor-helm#2180) - add proxy timeout for nginx https config by [@MinerYang](https://github.com/MinerYang) in [#2202](goharbor/harbor-helm#2202) - update adapter list for replication and proxy-cache by [@MinerYang](https://github.com/MinerYang) in [#2223](goharbor/harbor-helm#2223) - Fix ArgoCD sync by [@drewhemm](https://github.com/drewhemm) in [#2173](goharbor/harbor-helm#2173) - feat(gw-api): add support for HTTPRoutes by [@larivierec](https://github.com/larivierec) in [#2175](goharbor/harbor-helm#2175) - feat: Added support for configuring dual-stack services ([#2212](goharbor/harbor-helm#2212)) by [@reasonerjt](https://github.com/reasonerjt) in [#2226](goharbor/harbor-helm#2226) - Add support for trivy dbRepository and javaDBRepository by [@benji78](https://github.com/benji78) in [#1857](goharbor/harbor-helm#1857) - fix redis existingSecret with username url rendering by [@MinerYang](https://github.com/MinerYang) in [#2231](goharbor/harbor-helm#2231) - \[Cherry-pick]Move extraEnvVars and add tests by [@MinerYang](https://github.com/MinerYang) in [#2236](goharbor/harbor-helm#2236) - \[cherry-pick]bump k8s version matrix ([#2238](goharbor/harbor-helm#2238)) by [@MinerYang](https://github.com/MinerYang) in [#2239](goharbor/harbor-helm#2239) - Bump version to 1.14.0, appVersion to 2.14.0 by [@MinerYang](https://github.com/MinerYang) in [#2242](goharbor/harbor-helm#2242) #### New Contributors - [@sisilia91](https://github.com/sisilia91) made their first contribution in [#2167](goharbor/harbor-helm#2167) - [@rkthtrifork](https://github.com/rkthtrifork) made their first contribution in [#2180](goharbor/harbor-helm#2180) - [@drewhemm](https://github.com/drewhemm) made their first contribution in [#2173](goharbor/harbor-helm#2173) - [@larivierec](https://github.com/larivierec) made their first contribution in [#2175](goharbor/harbor-helm#2175) - [@benji78](https://github.com/benji78) made their first contribution in [#1857](goharbor/harbor-helm#1857) **Full Changelog**: <goharbor/harbor-helm@v1.17.0...v1.18.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1509 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

benji78 force-pushed the trivy-db-repository branch from 8d0b19c to e0582ef Compare November 11, 2024 16:59

Vad1mo previously requested changes Nov 11, 2024

View reviewed changes

reasonerjt mentioned this pull request Nov 12, 2024

ghcr rate limit for Trivy - overriding DB repositories goharbor/harbor#21163

Closed

benji78 marked this pull request as draft November 17, 2024 17:37

MinerYang self-assigned this Nov 18, 2024

MinerYang added the follow-up label Nov 18, 2024

benji78 force-pushed the trivy-db-repository branch from 9513f87 to 9625b00 Compare November 18, 2024 10:05

benji78 marked this pull request as ready for review November 20, 2024 17:41

benji78 force-pushed the trivy-db-repository branch from 9625b00 to 7b460f1 Compare November 20, 2024 18:56

MinerYang reviewed Jan 13, 2025

View reviewed changes

values.yaml Show resolved Hide resolved

values.yaml Show resolved Hide resolved

github-actions bot added Stale and removed Stale labels Mar 30, 2025

MinerYang mentioned this pull request May 6, 2025

Add support for SCANNER_TRIVY_DB_REPOSITORY and SCANNER_TRIVY_JAVA_DB_REPOSITORY #2181

Closed

github-actions bot added the Stale label May 31, 2025

github-actions bot removed the Stale label Jun 4, 2025

benji78 requested review from MinerYang and Vad1mo June 4, 2025 13:26

reasonerjt added needs/follow-up and removed follow-up labels Jun 9, 2025

MinerYang added the target/1.18.0 label Jul 28, 2025

MinerYang requested changes Aug 20, 2025

View reviewed changes

templates/trivy/trivy-sts.yaml Show resolved Hide resolved

MinerYang force-pushed the trivy-db-repository branch 2 times, most recently from c9de3e8 to 63e13f8 Compare September 1, 2025 07:01

MinerYang approved these changes Sep 3, 2025

View reviewed changes

feat: add support for trivy dbRepository and javaDBRepository

d3b5645

feat: support multiple db repositories Signed-off-by: Benjamin Bordes <benjaminbordes78@gmail.com> fix template error && add unittest for trivy db repository Signed-off-by: my036811 <miner.yang@broadcom.com>

MinerYang force-pushed the trivy-db-repository branch from 59c6d8e to d3b5645 Compare September 3, 2025 07:15

wy65701436 approved these changes Sep 3, 2025

View reviewed changes

wy65701436 merged commit 916ad42 into goharbor:main Sep 3, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for trivy dbRepository and javaDBRepository#1857

Add support for trivy dbRepository and javaDBRepository#1857
wy65701436 merged 1 commit intogoharbor:mainfrom
benji78:trivy-db-repository

benji78 commented Nov 11, 2024

Uh oh!

Vad1mo left a comment

Uh oh!

benji78 commented Nov 12, 2024

Uh oh!

benji78 commented Nov 17, 2024

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2025

Uh oh!

github-actions bot commented May 31, 2025

Uh oh!

LeclerT commented Jun 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

MinerYang left a comment

Uh oh!

wy65701436 left a comment

Uh oh!

Uh oh!

MinerYang commented Sep 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

benji78 commented Nov 11, 2024

Uh oh!

Vad1mo left a comment

Choose a reason for hiding this comment

Uh oh!

benji78 commented Nov 12, 2024

Uh oh!

benji78 commented Nov 17, 2024

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2025

Uh oh!

github-actions bot commented May 31, 2025

Uh oh!

LeclerT commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

MinerYang left a comment

Choose a reason for hiding this comment

Uh oh!

wy65701436 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MinerYang commented Sep 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LeclerT commented Jun 3, 2025 •

edited

Loading