update ECR adapter to allow for ecr-public to be mirored

[goshlanguage]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Allows ecr-public to be mirrored in the same way ecr-fips can be today

Issue being fixed

Fixes #(issue)
#22346

Please indicate you've done the following:

• Well Written Title and Summary of the PR
• Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
• Accepted the DCO. Commits without the DCO will delay acceptance.
• Made sure tests are passing and test coverage is added if needed.
• Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

[chlins]

@vincentni Please help to take a look for this change, thanks!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.01%. Comparing base (c8c11b4) to head (9cf665e).
⚠️ Report is 673 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #22351       +/-   ##
===========================================
+ Coverage   45.36%   66.01%   +20.64%     
===========================================
  Files         244     1074      +830     
  Lines       13333   116417   +103084     
  Branches     2719     2937      +218     
===========================================
+ Hits         6049    76854    +70805     
- Misses       6983    35314    +28331     
- Partials      301     4249     +3948     

Flag	Coverage Δ
unittests	66.01% <ø> (+20.64%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/pkg/reg/adapter/awsecr/adapter.go	66.03% <ø> (ø)

... and 988 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[goshlanguage]

@chlins I don't mean to nag, but is it possible we won't get a review from @vincentni? Their github history looks a little sparse, and its been a few weeks.

If there are other tests I can add to raise confidence here, I'm happy to do so. Please let me know.

Thanks!

[goshlanguage]

Hey folks, just wanted to check in again. Is there any appetite for this?

[github-actions]

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

[github-actions]

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

[chlins]

@Vad1mo Hi, could you please review this PR? I assume you have experience working with AWS ECR.

[chlins]

lgtm

[chlins]

@chlins I don't mean to nag, but is it possible we won't get a review from @vincentni? Their github history looks a little sparse, and its been a few weeks.

If there are other tests I can add to raise confidence here, I'm happy to do so. Please let me know.

Thanks!

@goshlanguage Sorry for the late response. Vincentni is an engineer from AWS and the maintainer of the ECR adapter, so I pinged him to review this PR. However, he doesn’t seem to be very active on GitHub. Since I don’t have much experience with ECR myself, I can only say that the code changes look good to me in theory. Let's wait for another maintainer with ECR experience to review it again.