Skip to content

Conversation

@adityachopra29
Copy link

@adityachopra29 adityachopra29 commented Jan 4, 2026

Comprehensive Summary of your change

Changes Made

  • Created a file common-gc-spec.ts containing all the tests.
  • Since most of the tests in this suite relied heavily on resource functions present in tests/resources, all necessary ones have been implemented.
    - They include setup, cleanup and navigation functions
    - Helper functions for pulling, pushing, tagging etc. images to a project
  • All tests are independent and self-contained.
  • Integration with the existing Playwright configuration and GitHub Actions workflow.

Issue being fixed

Fixes #22134

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Test Migration Status

This is a tracker showing the status of the tests migrated successfully

bupd and others added 20 commits October 24, 2025 13:44
Signed-off-by: bupd <[email protected]>

fix: playwright github action

Signed-off-by: bupd <[email protected]>

fix: playwright github action

Signed-off-by: bupd <[email protected]>

fix: rename login logout test

Signed-off-by: bupd <[email protected]>

fix: playwright testing

Signed-off-by: bupd <[email protected]>

feat: correct test

Signed-off-by: bupd <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
@adityachopra29 adityachopra29 requested a review from a team as a code owner January 4, 2026 20:31
@adityachopra29 adityachopra29 changed the title Migration of Common_gc tests from Robot to Playwright for Github Actions Migration of Common_gc tests from Robot to Playwright Jan 5, 2026
@adityachopra29
Copy link
Author

To the maintainers @bupd @Vad1mo @wy65701436 @OrlinVasilev. This pr is ready for review. Please take a look.

One thing to note here is that the tests Garbage Collection and Garbage Collection Accessory are check the working of the GC in different senarios, but GC does not consider artifacts uploaded in the past 2 hours, so it does not consider the project and artifacts that we push for testing.
Any suggestions on how to handle this?

@adityachopra29
Copy link
Author

Also, I found that there are a lot of different utility functions (for cosign/notation operations, docker functions, harbor navigation, etc) that I found will be used by other test cases as well, and everybody is reimplementing them for now...so I guess we need to modularize this at some point in time...so we should probably have an approach for this as well.
For now I have included them all in one file, but I can separate that out once the plan is decided. What do you suggest?

@adityachopra29
Copy link
Author

Lastly, currently, we don’t have a good developer setup for building Playwright tests. The playwright.yml file can’t be used to create a dev environment, which made local development inefficient for me. I’ve added a temporary workaround using sample.env, but a Docker-based setup similar to the Robot test cases would be a better long-term solution.

@bupd
Copy link
Contributor

bupd commented Jan 18, 2026

So currently the dev workflow is simple you just need to npm install which would install playwright

And for running playwright use npx playwright

On the sample env part and the playwright.yml this might be a good addition given that it simplifies the env required to run playwright tests locally

You can check the proposal i have linked the dockerfile for running playwright.

@adityachopra29
Copy link
Author

Okay..found the docker file

Signed-off-by: Aditya Chopra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Internal Pipeline to Github Actions

5 participants