-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Migration of Common_gc tests from Robot to Playwright #22707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]> fix: playwright github action Signed-off-by: bupd <[email protected]> fix: playwright github action Signed-off-by: bupd <[email protected]> fix: rename login logout test Signed-off-by: bupd <[email protected]> fix: playwright testing Signed-off-by: bupd <[email protected]> feat: correct test Signed-off-by: bupd <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
…es with cosign helper functions Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
…ions Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
Signed-off-by: Aditya Chopra <[email protected]>
|
To the maintainers @bupd @Vad1mo @wy65701436 @OrlinVasilev. This pr is ready for review. Please take a look. One thing to note here is that the tests Garbage Collection and Garbage Collection Accessory are check the working of the GC in different senarios, but GC does not consider artifacts uploaded in the past 2 hours, so it does not consider the project and artifacts that we push for testing. |
|
Also, I found that there are a lot of different utility functions (for cosign/notation operations, docker functions, harbor navigation, etc) that I found will be used by other test cases as well, and everybody is reimplementing them for now...so I guess we need to modularize this at some point in time...so we should probably have an approach for this as well. |
|
Lastly, currently, we don’t have a good developer setup for building Playwright tests. The playwright.yml file can’t be used to create a dev environment, which made local development inefficient for me. I’ve added a temporary workaround using sample.env, but a Docker-based setup similar to the Robot test cases would be a better long-term solution. |
|
So currently the dev workflow is simple you just need to npm install which would install playwright And for running playwright use npx playwright On the sample env part and the playwright.yml this might be a good addition given that it simplifies the env required to run playwright tests locally You can check the proposal i have linked the dockerfile for running playwright. |
|
Okay..found the docker file |
Signed-off-by: Aditya Chopra <[email protected]>
Comprehensive Summary of your change
This PR implements the complete migration of the Common_GC.robot robot test suite to Playwright.
This PR builds upon the existing PR for playwright setup feat: Add Playwright setup #22462.
Changes Made
- They include setup, cleanup and navigation functions
- Helper functions for pulling, pushing, tagging etc. images to a project
Issue being fixed
Fixes #22134
Please indicate you've done the following:
Test Migration Status
This is a tracker showing the status of the tests migrated successfully