Skip to content

fix: Update Verify Remote Cert tooltip for registry endpoints#22812

Open
dee077 wants to merge 2 commits intogoharbor:mainfrom
dee077:fix/22806-tooltip-verify-remote-cert
Open

fix: Update Verify Remote Cert tooltip for registry endpoints#22812
dee077 wants to merge 2 commits intogoharbor:mainfrom
dee077:fix/22806-tooltip-verify-remote-cert

Conversation

@dee077
Copy link

@dee077 dee077 commented Feb 3, 2026

Comprehensive Summary of your change

Updated the tooltip text as per the issue description

Screenshot from 2026-02-04 03-32-49

Issue being fixed

Fixes #22806

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@dee077 dee077 requested a review from a team as a code owner February 3, 2026 22:22
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.93%. Comparing base (c8c11b4) to head (7dbef45).
⚠️ Report is 671 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22812       +/-   ##
===========================================
+ Coverage   45.36%   65.93%   +20.56%     
===========================================
  Files         244     1074      +830     
  Lines       13333   116419   +103086     
  Branches     2719     2937      +218     
===========================================
+ Hits         6049    76758    +70709     
- Misses       6983    35418    +28435     
- Partials      301     4243     +3942     
Flag Coverage Δ
unittests 65.93% <ø> (+20.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 989 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wy65701436
Copy link
Contributor

@dee077 thanks for your contribution. We should update all the i18n files, such as CN, FR, etc.

Since we’re reaching RC this week and this issue must be fixed by the end of the week, please let me know if this is feasible. Otherwise, we can take it over.

-        "CA_CERTIFICATE_TOOLTIP": "Provide a PEM-encoded CA certificate to verify the registry's TLS certificate. Leave empty to use the system CA pool. This field is only available when 'Verify Remote Cert' is enabled.",
-        "CA_CERTIFICATE_HELPER": "Optional. Paste the PEM-encoded CA certificate here to trust self-signed or private CA certificates for this endpoint. If left empty, Harbor will use the system CA pool."
+        "CA_CERTIFICATE_TOOLTIP": "Provide a PEM-encoded CA certificate to trust additional CA certificates for this registry. The custom CA will be added to the system CA pool, allowing Harbor to trust both system-signed and custom-signed certificates. Leave empty to use only the system CA pool. This field is only available when 'Verify Remote Cert' is enabled.",
+        "CA_CERTIFICATE_HELPER": "Optional. Paste the PEM-encoded CA certificate here to trust self-signed or private CA certificates for this endpoint. The certificate will be added to the system CA pool, not replace it."

@dee077
Copy link
Author

dee077 commented Feb 11, 2026

Sure! I will make it ready before the end of this week

Fixes goharbor#22806

Signed-off-by: dee077 <deepanshu.sahu27@gmail.com>
Signed-off-by: dee077 <deepanshu.sahu27@gmail.com>
@dee077 dee077 force-pushed the fix/22806-tooltip-verify-remote-cert branch from 7dbef45 to 683497d Compare February 12, 2026 19:14
@dee077
Copy link
Author

dee077 commented Feb 17, 2026

Hi @wy65701436, I have updated with the requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inaccurate ToolTip about Verify Remote Cert when create registry endpoint

6 participants