fix: Update Verify Remote Cert tooltip for registry endpoints#22812
Open
dee077 wants to merge 2 commits intogoharbor:mainfrom
Open
fix: Update Verify Remote Cert tooltip for registry endpoints#22812dee077 wants to merge 2 commits intogoharbor:mainfrom
dee077 wants to merge 2 commits intogoharbor:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22812 +/- ##
===========================================
+ Coverage 45.36% 65.93% +20.56%
===========================================
Files 244 1074 +830
Lines 13333 116419 +103086
Branches 2719 2937 +218
===========================================
+ Hits 6049 76758 +70709
- Misses 6983 35418 +28435
- Partials 301 4243 +3942
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
@dee077 thanks for your contribution. We should update all the i18n files, such as CN, FR, etc. Since we’re reaching RC this week and this issue must be fixed by the end of the week, please let me know if this is feasible. Otherwise, we can take it over. |
Author
|
Sure! I will make it ready before the end of this week |
Fixes goharbor#22806 Signed-off-by: dee077 <deepanshu.sahu27@gmail.com>
Signed-off-by: dee077 <deepanshu.sahu27@gmail.com>
7dbef45 to
683497d
Compare
Author
|
Hi @wy65701436, I have updated with the requested changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
Updated the tooltip text as per the issue description
Issue being fixed
Fixes #22806
Please indicate you've done the following: