fix: wrong operation response name for UpdateRepository#22851
Open
liubin wants to merge 1 commit intogoharbor:mainfrom
Open
fix: wrong operation response name for UpdateRepository#22851liubin wants to merge 1 commit intogoharbor:mainfrom
liubin wants to merge 1 commit intogoharbor:mainfrom
Conversation
Signed-off-by: Bin Liu <lb203159@antfin.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22851 +/- ##
===========================================
+ Coverage 45.36% 66.00% +20.64%
===========================================
Files 244 1074 +830
Lines 13333 116417 +103084
Branches 2719 2937 +218
===========================================
+ Hits 6049 76846 +70797
- Misses 6983 35321 +28338
- Partials 301 4250 +3949
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the HTTP responder returned by the v2.0 UpdateRepository handler so it matches the updateRepository operation (and doesn’t incorrectly return the deleteRepository operation response).
Changes:
- Update
UpdateRepositoryto returnoperation.NewUpdateRepositoryOK()instead ofoperation.NewDeleteRepositoryOK().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: