Skip to content

fix: wrong operation response name for UpdateRepository#22851

Open
liubin wants to merge 1 commit intogoharbor:mainfrom
liubin:fix-wrong-response-operation-name
Open

fix: wrong operation response name for UpdateRepository#22851
liubin wants to merge 1 commit intogoharbor:mainfrom
liubin:fix-wrong-response-operation-name

Conversation

@liubin
Copy link
Contributor

@liubin liubin commented Feb 14, 2026

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Bin Liu <lb203159@antfin.com>
@liubin liubin requested a review from a team as a code owner February 14, 2026 05:44
@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.00%. Comparing base (c8c11b4) to head (6aced4b).
⚠️ Report is 673 commits behind head on main.

Files with missing lines Patch % Lines
src/server/v2.0/handler/repository.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22851       +/-   ##
===========================================
+ Coverage   45.36%   66.00%   +20.64%     
===========================================
  Files         244     1074      +830     
  Lines       13333   116417   +103084     
  Branches     2719     2937      +218     
===========================================
+ Hits         6049    76846    +70797     
- Misses       6983    35321    +28338     
- Partials      301     4250     +3949     
Flag Coverage Δ
unittests 66.00% <0.00%> (+20.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/server/v2.0/handler/repository.go 0.00% <0.00%> (ø)

... and 988 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the HTTP responder returned by the v2.0 UpdateRepository handler so it matches the updateRepository operation (and doesn’t incorrectly return the deleteRepository operation response).

Changes:

  • Update UpdateRepository to return operation.NewUpdateRepositoryOK() instead of operation.NewDeleteRepositoryOK().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins added the release-note/update Update or Fix label Feb 16, 2026
@chlins chlins enabled auto-merge (squash) February 16, 2026 09:43
Copy link
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants