Always strip taxonomy name prefix from term name#13423
Closed
jasonccox wants to merge 1 commit intogohugoio:masterfrom
Closed
Always strip taxonomy name prefix from term name#13423jasonccox wants to merge 1 commit intogohugoio:masterfrom
jasonccox wants to merge 1 commit intogohugoio:masterfrom
Conversation
If the taxonomy name differs when normalized versus unnormalized (e.g., because it has a space in it which is converted to a dash when normalized), the plural tree key will not match as a prefix to the term's base path (which is normalized). Use the non-normalized taxonomy name instead to ensure that the prefix always matches and is trimmed. Fixes: gohugoio#13422 Signed-off-by: Jason Cox <me@jasoncarloscox.com>
Member
|
I have verified that this change addresses both of the cases described in #13422. |
Author
|
Looks like this got fixed in #14518 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the taxonomy name differs when normalized versus unnormalized (e.g., because it has a space in it which is converted to a dash when normalized), the plural tree key will not match as a prefix to the term's base path (which is normalized). Use the non-normalized taxonomy name instead to ensure that the prefix always matches and is trimmed.
Fixes: #13422