[apang, bilfash][GOJ-79488] fix xDS to using checks watchplan on usin…#31
Open
meong1234 wants to merge 1 commit intogojek:masterfrom
Open
[apang, bilfash][GOJ-79488] fix xDS to using checks watchplan on usin…#31meong1234 wants to merge 1 commit intogojek:masterfrom
meong1234 wants to merge 1 commit intogojek:masterfrom
Conversation
…g healthy Catalog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when enableHealthCheck is true it just fetches healthy services.
we figure out that when service registers to Consul, it starts on critical state, and later will become healthy. Some intermittent issue happens if we use service watch plan , when it triggers the event (ex: registered event), xDS fetch the catalog, registered service still on the critical state, but when it becomes healthy xDS not get any event.
so instead watch for a service event, we should watch checks/healthy event on consul