fix: ensure playlist and song IDs are non-null before processing like status and renaming

Author: gokadzev

lib/screens/playlist_page.dart

@@ -72,7 +72,7 @@ class _PlaylistPageState extends State<PlaylistPage> {
   _originalPlaylistList; // Keep original order separately
 
   late final playlistLikeStatus = ValueNotifier<bool>(
-    isPlaylistAlreadyLiked(widget.playlistId),
+    widget.playlistId != null && isPlaylistAlreadyLiked(widget.playlistId!),
   );
   bool playlistOfflineStatus = false;
 
@@ -104,6 +104,7 @@ class _PlaylistPageState extends State<PlaylistPage> {
 
   @override
   void dispose() {
+    playlistLikeStatus.dispose();
     super.dispose();
   }
 
@@ -534,7 +535,10 @@ class _PlaylistPageState extends State<PlaylistPage> {
     }
   }
 
-  void _updateSongsListOnRemove(int indexOfRemovedSong, dynamic songToRemove) {
+  void _updateSongsListOnRemove(
+    int indexOfRemovedSong,
+    Map<String, dynamic> songToRemove,
+  ) {
     _originalPlaylistList.removeWhere((s) => s['ytid'] == songToRemove['ytid']);
     final playlistId = _playlist['ytid'];
     if (mounted) {

lib/services/common_services.dart

@@ -215,7 +215,7 @@ List _deduplicateAndShuffle(List playlistSongs) {
   return uniqueSongs;
 }
 
-Future<void> updateSongLikeStatus(dynamic songId, bool add) async {
+Future<void> updateSongLikeStatus(String songId, bool add) async {
   try {
     if (add) {
       if (!userLikedSongsList.any((song) => song['ytid'] == songId)) {
@@ -250,7 +250,7 @@ void moveLikedSong(int oldIndex, int newIndex) {
 }
 
 Future<void> renameSongInLikedSongs(
-  dynamic songId,
+  String songId,
   String newTitle,
   String newArtist,
 ) async {
@@ -276,13 +276,13 @@ Future<void> renameSongInLikedSongs(
   }
 }
 
-bool isSongAlreadyLiked(songIdToCheck) =>
+bool isSongAlreadyLiked(String songIdToCheck) =>
     userLikedSongsList.any((song) => song['ytid'] == songIdToCheck);
 
-bool isPlaylistAlreadyLiked(playlistIdToCheck) =>
+bool isPlaylistAlreadyLiked(String playlistIdToCheck) =>
     userLikedPlaylists.any((playlist) => playlist['ytid'] == playlistIdToCheck);
 
-bool isSongAlreadyOffline(songIdToCheck) =>
+bool isSongAlreadyOffline(String songIdToCheck) =>
     userOfflineSongs.any((song) => song['ytid'] == songIdToCheck);
 
 Map<String, dynamic> getOfflineSongByYtid(String ytid) {
@@ -618,7 +618,7 @@ Future<bool> makeSongOffline(dynamic song) async {
   }
 }
 
-Future<bool> removeSongFromOffline(dynamic songId) async {
+Future<bool> removeSongFromOffline(String songId) async {
   try {
     final audioPath = FilePaths.getAudioPath(songId);
     final audioFile = File(audioPath);
@@ -700,7 +700,7 @@ Future<File?> _downloadAndSaveArtworkFile(String url, String filePath) async {
 
 const recentlyPlayedSongsLimit = 250;
 
-Future<void> updateRecentlyPlayed(dynamic songId) async {
+Future<void> updateRecentlyPlayed(String songId) async {
   try {
     if (userRecentlyPlayed.isNotEmpty &&
         userRecentlyPlayed.length == 1 &&
@@ -750,7 +750,7 @@ Future<void> updateRecentlyPlayed(dynamic songId) async {
   }
 }
 
-Future<void> removeFromRecentlyPlayed(dynamic songId) async {
+Future<void> removeFromRecentlyPlayed(String songId) async {
   if (userRecentlyPlayed.any((song) => song['ytid'] == songId)) {
     userRecentlyPlayed.removeWhere((song) => song['ytid'] == songId);
     currentRecentlyPlayedLength.value = userRecentlyPlayed.length;

lib/services/playlists_manager.dart

@@ -848,7 +848,7 @@ Future<List> _loadSongsForPlaylist(Map playlist) async {
 }
 
 Future<List> getSongsFromPlaylist(
-  dynamic playlistId, {
+  String playlistId, {
   String? playlistImage,
 }) async {
   final songList = await getData('cache', 'playlistSongs$playlistId') ?? [];
@@ -884,8 +884,8 @@ Future updatePlaylistList(BuildContext context, String playlistId) async {
 }
 
 Future<void> renameSongInPlaylist(
-  dynamic playlistId,
-  dynamic songId,
+  String playlistId,
+  String songId,
   String newTitle,
   String newArtist,
 ) async {

lib/widgets/playlist_bar.dart

@@ -48,7 +48,7 @@ class PlaylistBar extends StatelessWidget {
     this.isAlbum = false,
     this.borderRadius = BorderRadius.zero,
   }) : playlistLikeStatus = ValueNotifier<bool>(
-         isPlaylistAlreadyLiked(playlistId),
+         playlistId != null && isPlaylistAlreadyLiked(playlistId),
        );
 
   final Map? playlistData;

lib/widgets/song_bar.dart

@@ -324,7 +324,7 @@ class _SongBarState extends State<SongBar> {
         }
       } else if (widget.playlistId != null) {
         await renameSongInPlaylist(
-          widget.playlistId,
+          widget.playlistId!,
           _ytid,
           newTitle,
           newArtist,