Open
Conversation
11f2a26 to
8d20ea1
Compare
Author
|
@dhui Can you see this PR? We are waiting YDB support in golang-migrate very much |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for YDB (Yandex Database) to golang-migrate, implementing a complete database driver with migration capabilities, locking mechanisms, and comprehensive test coverage.
Key Changes:
- New YDB database driver with full migration lifecycle support (Open, Close, Lock, Unlock, Run, SetVersion, Version, Drop)
- Extensive test suite including integration tests with Docker containers
- Complete documentation with connection string format and configuration options
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
internal/cli/build_ydb.go |
Build tag configuration to conditionally include YDB driver in CLI builds |
go.mod / go.sum |
Added YDB SDK dependencies (v3.100.0) and related transitive dependencies |
database/ydb/ydb.go |
Main driver implementation with connection handling, migrations, versioning, and locking |
database/ydb/ydb_test.go |
Comprehensive test suite with Docker-based integration tests for multiple YDB versions |
database/ydb/examples/migrations/*.sql |
Example migrations demonstrating YDB-specific features (tables, columns, indexes, topics) |
database/ydb/README.md |
Detailed documentation covering connection strings, authentication methods, TLS options, and troubleshooting |
README.md |
Added YDB to the list of supported database drivers |
Makefile |
Added ydb to the DATABASE variable for build/test targets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asmyasnikov
commented
Nov 26, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
f142410 to
ac4c602
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added YDB support to golang-migrate
This PR implements support for YDB in golang-migrate. The main changes include:
How to Test: