Add support for mongo-driver v2 without breaking 1.x compatibility #1265
+881
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilsinghcohesity
force-pushed
the
Nikhil_golang_migrate_V2
branch
from
64dd4ca to
13f2229
Compare
Author
|
@dhui and reviewers, can you please review this PR ? |
Author
|
@dhui please review the changes. And let me know if i can do anything to expedite the process. |
|
Any update on this is it going to be accepted? |
|
@dhui Can this be merged and released as a new version? This is really problematic for using the latest drivers. |
|
@Fontinalis Or maybe you Barnabás? :) Is there anything that can be done here? :) Köszi! :) |
| if err == nil { | ||
| err = e | ||
| } else { | ||
| err = multierror.Append(err, e) |
There was a problem hiding this comment.
Better to use errors.Join
|
@dhui Any news on this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the MongoDB driver in the newly released V2 version, while ensuring compatibility with the 1.x versions of the MongoDB driver for flexibility in development.
This update does not break compatibility with any 1.x or earlier versions of the MongoDB driver.
The migration process follows the guidelines provided in the official MongoDB driver migration guide: MongoDB Go Driver v2 Migration Guide.
Ref : pgxv4 and pgxv5 db driver
@dhui Please take a look.