fix(mongodb): replace deprecated DecodeBytes - #1432
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a direct, equivalent replacement of a deprecated API with the supported decode path and appears consistent with the existing isMaster struct decoding logic.
Pull request overview
This PR updates the MongoDB replica-set initialization helper in the MongoDB test suite to avoid using the deprecated mongo.SingleResult.DecodeBytes, improving compatibility with newer mongo-driver versions (and removing a staticcheck failure in v1.17.7).
Changes:
- Replace
SingleResult.DecodeBytes+bson.Unmarshalwith a singleSingleResult.Decode(&status)call inwaitForReplicaInit.
File summaries
| File | Description |
|---|---|
database/mongodb/mongodb_test.go |
Simplifies RunCommand(...).Decode handling by decoding directly into the isMaster struct instead of decoding raw bytes and unmarshalling. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Replace the deprecated
SingleResult.DecodeBytescall withSingleResult.Decode.This keeps the MongoDB test compatible with both the current driver version and
v1.17.7, whereDecodeBytescauses astaticcheckfailure. It unblocks #1429.Testing