Skip to content

Fix Clickhouse driver to work correctly with v2 #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Fix Clickhouse driver to work correctly with v2 #950

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
60d4844
Fix Clickhouse driver to work correctly with v2
jhzn Jun 26, 2023
994a73a
Fix go.mod
jhzn Jun 26, 2023
b5f2d09
Revert go.mod file to be able to merge to main repo
jhzn Jun 28, 2023
419f1ac
Merge branch 'master' into only_go_change
jhzn Jul 4, 2023
7d9c74d
Merge branch 'master' into only_go_change
jhzn Jul 6, 2023
7ad80c9
Merge remote-tracking branch 'origin/master' into only_go_change
jhzn Jan 11, 2024
87481e1
Merge remote-tracking branch 'origin/master' into only_go_change
jhzn Apr 17, 2024
0024504
Merge remote-tracking branch 'origin/master' into only_go_change
jhzn May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion database/clickhouse/clickhouse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,14 @@ func (ch *ClickHouse) SetVersion(version int, dirty bool) error {
}

query := "INSERT INTO " + ch.config.MigrationsTable + " (version, dirty, sequence) VALUES (?, ?, ?)"
if _, err := tx.Exec(query, version, bool(dirty), time.Now().UnixNano()); err != nil {
stmt, err := tx.Prepare(query)
if err != nil {
if rollbackErr := tx.Rollback(); rollbackErr != nil {
return fmt.Errorf("error during prepare statement %w and rollback %s", err, rollbackErr)
}
return err
}
if _, err := stmt.Exec(int64(version), bool(dirty), uint64(time.Now().UnixNano())); err != nil {
return &database.Error{OrigErr: err, Query: []byte(query)}
}

Expand Down
Loading