refactor: refactor worker and task metrics to use int64 types #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `BusyWorkers` type from `uint64` to `int64` - Add `CompletedTasks` method to `Metric` interface and implementation - Update `IncBusyWorker` and `DecBusyWorker` to use `atomic.AddInt64` - Modify test assertions to use `uint64` and `int64` types - Change `defaultWorkerCount` and related functions from `int` to `int64` - Update `NewPool` and related functions to use `int64` for size and worker count - Add `CompletedTasks` method to `Queue` and update related methods to use `uint64` and `int64` types Signed-off-by: appleboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BusyWorkerstype fromuint64toint64CompletedTasksmethod toMetricinterface and implementationIncBusyWorkerandDecBusyWorkerto useatomic.AddInt64uint64andint64typesdefaultWorkerCountand related functions frominttoint64NewPooland related functions to useint64for size and worker countCompletedTasksmethod toQueueand update related methods to useuint64andint64types